Skip to content

use GCC/MSVC compatible __VA_ARGS__

Tyler Retzlaff dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15eal: use GCC and MSVC common VA ARGS extensionlib/eal/common/eal_trace.h+4 -40 replies
2/15bpf: use GCC and MSVC common VA ARGS extensionlib/bpf/bpf_impl.h+2 -20 replies
3/15cfgfile: use GCC and MSVC common VA ARGS extensionlib/cfgfile/rte_cfgfile.c+2 -21 reply
4/15cmdline: use GCC and MSVC common VA ARGS extensionlib/cmdline/cmdline_parse.c lib/cmdline/cmdline_parse_num.c+3 -31 reply
5/15ip_frag: use GCC and MSVC common VA ARGS extensionlib/ip_frag/ip_frag_common.h+2 -20 replies
6/15compressdev: use GCC and MSVC common VA ARGS extensionlib/compressdev/rte_compressdev_internal.h+2 -20 replies
7/15metrics: use GCC and MSVC common VA ARGS extensionlib/metrics/rte_metrics_telemetry.c+6 -60 replies
8/15mldev: use GCC and MSVC common VA ARGS extensionlib/mldev/rte_mldev.h+2 -20 replies
9/15net: use GCC and MSVC common VA ARGS extensionlib/net/rte_net_crc.c+2 -20 replies
10/15pdump: use GCC and MSVC common VA ARGS extensionlib/pdump/rte_pdump.c+2 -20 replies
11/15power: use GCC and MSVC common VA ARGS extensionlib/power/power_common.h+3 -30 replies
12/15rawdev: use GCC and MSVC common VA ARGS extensionlib/rawdev/rte_rawdev_pmd.h+9 -91 reply
13/15rcu: use GCC and MSVC common VA ARGS extensionlib/rcu/rte_rcu_qsbr.c lib/rcu/rte_rcu_qsbr.h+8 -80 replies
14/15stack: use GCC and MSVC common VA ARGS extensionlib/stack/stack_pvt.h+8 -80 replies
15/15vhost: use GCC and MSVC common VA ARGS extensionlib/vhost/vhost.h lib/vhost/vhost_crypto.c+11 -110 replies

Reviews trailers per patch

3 of 15 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBruce RichardsonMorten BrørupHemant AgrawalStephen HemmingerKonstantin Ananyev
SeriesSeries-acked-by Series-acked-by Series-acked-by Series-acked-by A-b A-b
1/15
2/15
3/15R-b
4/15R-b
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15A-b
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/15] use GCC/MSVC compatible __VA_ARGS__

MSVC does not support GCC args... forwarding of args replace with ... and __VA_ARGS__ when forwarding. Both forms of forwarding are a compiler extension but the latter is supported by both MSVC and GCC.

I have not been able to exhaustively test all versions of GCC so please provide feedback as appropriate.

Tyler Retzlaff (15):
eal: use GCC and MSVC common VA ARGS extension
bpf: use GCC and MSVC common VA ARGS extension
cfgfile: use GCC and MSVC common VA ARGS extension
cmdline: use GCC and MSVC common VA ARGS extension
ip_frag: use GCC and MSVC common VA ARGS extension
compressdev: use GCC and MSVC common VA ARGS extension
metrics: use GCC and MSVC common VA ARGS extension
mldev: use GCC and MSVC common VA ARGS extension
net: use GCC and MSVC common VA ARGS extension
pdump: use GCC and MSVC common VA ARGS extension
power: use GCC and MSVC common VA ARGS extension
rawdev: use GCC and MSVC common VA ARGS extension
rcu: use GCC and MSVC common VA ARGS extension
stack: use GCC and MSVC common VA ARGS extension
vhost: use GCC and MSVC common VA ARGS extension

 lib/bpf/bpf_impl.h                         |  4 ++--
 lib/cfgfile/rte_cfgfile.c                  |  4 ++--
 lib/cmdline/cmdline_parse.c                |  2 +-
 lib/cmdline/cmdline_parse_num.c            |  4 ++--
 lib/compressdev/rte_compressdev_internal.h |  4 ++--
 lib/eal/common/eal_trace.h                 |  8 ++++----
 lib/ip_frag/ip_frag_common.h               |  4 ++--
 lib/metrics/rte_metrics_telemetry.c        | 12 ++++++------
 lib/mldev/rte_mldev.h                      |  4 ++--
 lib/net/rte_net_crc.c                      |  4 ++--
 lib/pdump/rte_pdump.c                      |  4 ++--
 lib/power/power_common.h                   |  6 +++---
 lib/rawdev/rte_rawdev_pmd.h                | 18 +++++++++---------
 lib/rcu/rte_rcu_qsbr.c                     |  4 ++--
 lib/rcu/rte_rcu_qsbr.h                     | 12 ++++++------
 lib/stack/stack_pvt.h                      | 16 ++++++++--------
 lib/vhost/vhost.h                          |  8 ++++----
 lib/vhost/vhost_crypto.c                   | 14 +++++++-------
 18 files changed, 66 insertions(+), 66 deletions(-)
Signature · 1 line
1.8.3.1