build and install only one library type on Windows
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest2 patches 3 repliesIn review
- v42 patches 0 repliesSuperseded
- v32 patches 2 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 8 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
v4 from the cover letter
* use add_project_link_arguments() and move addition of linker and compiler arguments required only dynamic linking to block where it is determined is_shared_enabled=true and don't specify when is_shared_enabled=false.
* unconditionally initialize shared_deps = {} and get rid of else leg of conditional evaluation in drivers/meson.build and lib/meson.build.
* drop change to octeontx meson.build.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | build: build only one library type on Windowsconfig/ drivers/ lib/ | +75 | 1 reply | |
| 2/2 | buildtools: when building static library use static depsbuildtools/ | +3 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Richardson |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/2] build and install only one library type on Windows
MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables.
Disable building of shared libraries with LLVM and MinGW so that
remaining __declspec macros needed for the functional libraries built by
MSVC can be used without triggering errors in LLVM and MinGW builds.
For Windows only install the default_library type to avoid confusion.
Windows builds cannot build both shared and static in a single pass so
install only the functional variant
MSVC does not guarantee any kind of compatibility for static libraries so they should not be packaged and instead they should be rebuilt along with the application using the same version of the compiler & linker. Because of this we have chosen to build only one library type at a time instead of compiling twice to produce both types in a single pass.
thanks Bruce for all the discussion/feedback!
v5: set RTE_BUILD_SHARED_LIB in a single location when building with msvc
and is_shared_enabled instead of scattered over various meson.build files.
v4:
* use add_project_link_arguments() and move addition of linker and compiler arguments required only dynamic linking to block where it is determined is_shared_enabled=true and don't specify when is_shared_enabled=false.
* unconditionally initialize shared_deps = {} and get rid of else leg of conditional evaluation in drivers/meson.build and lib/meson.build.
* drop change to octeontx meson.build.
v3:
* condense library, target and toolchain type logic determining values for is_shared_enabled,install_{static,shared} values.
* define empty shared_dep object to allow unconditional evaluation of shared variables even when is_shared_enabled is false.
* use default_library() string to determine deps for chkincs.
Tyler Retzlaff (2):
build: build only one library type on Windows
buildtools: when building static library use static deps
buildtools/chkincs/meson.build | 5 ++-- config/meson.build | 24 +++++++++++++++ drivers/meson.build | 59 ++++++++++++++++--------------------- lib/meson.build | 67 ++++++++++++++++-------------------------- 4 files changed, 78 insertions(+), 77 deletions(-)
Signature · 1 line
1.8.3.1