Skip to content

remove use of RTE_MARKER fields in libraries

Tyler Retzlaff dpdk-dev 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest4 patches 0 repliesNew
  2. v104 patches 6 repliesSuperseded
  3. v94 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v84 patches0 repliesSuperseded
v74 patches10 repliesSuperseded

Changes in v11 from the cover letter

* correct doxygen comment style for field documentation.

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/i40e: use inline prefetch functiondrivers/net/i40e/i40e_rxtx_vec_avx512.c+1 -10 replies
2/4mbuf: remove rte marker fieldsdevtools/libabigail.abignore doc/guides/rel_notes/release_24_07.rst lib/mbuf/rte_mbuf.h +1 more+116 -990 replies
3/4security: remove rte marker fieldsdoc/guides/rel_notes/release_24_07.rst lib/security/rte_security_driver.h+6 -20 replies
4/4cryptodev: remove rte marker fieldsdoc/guides/rel_notes/release_24_07.rst lib/cryptodev/cryptodev_pmd.h+6 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMorten BrørupStephen Hemminger
1/4R-b A-b
2/4R-b A-b
3/4R-b A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH v11 0/4] remove use of RTE_MARKER fields in libraries

As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields.

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields.

For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch.

Provide new rearm_data and rx_descriptor_fields1 fields in anonymous unions as single element arrays of with types matching the original markers to maintain API compatibility.

Note: diff is easier viewed with -b due to additional nesting from
unions / structs that have been introduced.

v11:
* correct doxygen comment style for field documentation.

v10:
* move removal notices in in release notes from 24.03 to 24.07.

v9:
* provide narrowest possible libabigail.abignore to suppress removal of fields that were agreed are not actual abi changes.

v8:
* rx_descriptor_fields1 array is now constexpr sized to 24 / sizeof(void *) so that the array encompasses fields accessed via the array.
* add a comment to rx_descriptor_fields1 array site noting that void * type of elements is retained for compatibility with existing drivers.
* clean up comments of fields in rte_mbuf to be before the field they apply to instead of after.
* duplicate alignas(RTE_CACHE_LINE_MIN_SIZE) into both legs of conditional compile for first field of cacheline 1 instead of once before conditional compile block.

v7:
* complete re-write of series, previous versions not noted. all reviewed-by and acked-by tags (if any) were removed.

Tyler Retzlaff (4):
net/i40e: use inline prefetch function
mbuf: remove rte marker fields
security: remove rte marker fields
cryptodev: remove rte marker fields

 devtools/libabigail.abignore            |   6 +
 doc/guides/rel_notes/release_24_07.rst  |   9 ++
 drivers/net/i40e/i40e_rxtx_vec_avx512.c |   2 +-
 lib/cryptodev/cryptodev_pmd.h           |   5 +-
 lib/mbuf/rte_mbuf.h                     |   4 +-
 lib/mbuf/rte_mbuf_core.h                | 202 +++++++++++++++++---------------
 lib/security/rte_security_driver.h      |   5 +-
 7 files changed, 129 insertions(+), 104 deletions(-)
Signature · 1 line
1.8.3.1