ethtool: provide the dim profile fine-tuning channel
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v15 Latest5 patches 0 repliesApplied 5/5
- v14 posting 2/25 patches 11 repliesSuperseded
- v14 posting 1/25 patches 3 repliesSuperseded
Earlier versions · 13
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v13 | 4 patches | 9 replies | Superseded | |
| v12 | 4 patches | 8 replies | Superseded | |
| v11 | 4 patches | 8 replies | Superseded | |
| v10 | 4 patches | 6 replies | Superseded | |
| v9 | 4 patches | 11 replies | Superseded | |
| v8 | 4 patches | 7 replies | Superseded | |
| v7 posting 2/2 | 4 patches | 2 replies | Superseded | |
| v7 posting 1/2 | 4 patches | 3 replies | Superseded | |
| v6 | 4 patches | 9 replies | Superseded | |
| v5 | 4 patches | 6 replies | Superseded | |
| v4 | 4 patches | 3 replies | Superseded | |
| v3 | 3 patches | 2 replies | Superseded | |
| v2 | 2 patches | 11 replies | Superseded |
Changes in v15 from the cover letter
- Modify the mod bit and add some hints.
Patches in v15 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | linux/dim: move useful macros to .h fileinclude/ lib/ | +7 | 0 replies | Applied |
| 2/5 | dim: make DIMLIB dependent on NETdrivers/ lib/ | +2 | 0 replies | Applied |
| 3/5 | ethtool: provide customized dim profile managementDocumentation/ Documentation/ Documentation/ +7 more | +509 | 0 replies | Applied |
| 4/5 | dim: add new interfaces for initialization and getting resultsinclude/ lib/ | +116 | 0 replies | Applied |
| 5/5 | virtio-net: support dim profile fine-tuningdrivers/ | +47 | 0 replies | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Simon Horman |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v15 0/5] ethtool: provide the dim profile fine-tuning channel
The NetDIM library provides excellent acceleration for many modern network cards. However, the default profiles of DIM limits its maximum capabilities for different NICs, so providing a way which the NIC can be custom configured is necessary.
Currently, the way is based on the commonly used "ethtool -C".
For example,
on the server side, the virtio-net NIC with rx dim enabled has 8 queues and runs nginx.
The client uses the following command to send traffic to the server:
./wrk http://server_ip:80 -c 64 -t 5 -d 30
Then adjust the default rx-profile for server dim to
{.usec = 1, .pkts = 256, .comps = n/a,},
{.usec = 8, .pkts = 256, .comps = n/a,},
{.usec = 30, .pkts = 256, .comps = n/a,},
{.usec = 64, .pkts = 256, .comps = n/a,},
{.usec = 128, .pkts = 256, .comps = n/a,}
The server PPS is improved by 20%+.
Please review, thank you very much!
Changelog
=====v14->v15:
- Modify the mod bit and add some hints.
Jakub feedback: Use RESEND to refresh the review queue.
v13->v14:
- Make DIMLIB dependent on NET (patch 2/5).
v12->v13:
- Rebase net-next to fix the one-line conflict.
- Update tiny comments.
- Config ETHTOOL_NETLINK to select DIMLIB.
v11->v12:
- Remove the use of IS_ENABLED(DIMLIB).
- Update Simon's htmldoc hint.
v10->v11:
- Fix and clean up some issues from Kuba, thanks.
- Rebase net-next/main
v9->v10:
- Collect dim related flags/mode/work into one place.
- Use rx_profile + tx_profile instead of four profiles.
- Add several helps.
- Update commit logs.
v8->v9:
- Fix the compilation error of conflicting names of rx_profile in dim.h and ice driver: in dim.h, rx_profile is replaced with dim_rx_profile. So does tx_profile.
v7->v8:
- Use kmemdup() instead of kzalloc()/memcpy() in dev_dim_profile_init().
v6->v7:
- A new wrapper struct pointer is used in struct net_device.
- Add IS_ENABLED(CONFIG_DIMLIB) to avoid compiler warnings.
- Profile fields changed from u16 to u32.
v5->v6:
- Place the profile in netdevice to bypass the driver.
The interaction code of ethtool <-> kernel has not changed at all,
only the interaction part of kernel <-> driver has changed.v4->v5:
- Update some snippets from Kuba.
v3->v4:
- Some tiny updates and patch 1 only add a new comment.
v2->v3:
- Break up the attributes to avoid the use of raw c structs.
- Use per-device profile instead of global profile in the driver.
v1->v2:
- Use ethtool tool instead of net-sysfs.
Heng Qi (5):
linux/dim: move useful macros to .h file
dim: make DIMLIB dependent on NET
ethtool: provide customized dim profile management
dim: add new interfaces for initialization and getting results
virtio-net: support dim profile fine-tuning
Documentation/netlink/specs/ethtool.yaml | 31 +++ Documentation/networking/ethtool-netlink.rst | 8 + Documentation/networking/net_dim.rst | 42 +++ drivers/net/virtio_net.c | 54 +++- drivers/soc/fsl/Kconfig | 2 +- include/linux/dim.h | 113 ++++++++ include/linux/ethtool.h | 4 +- include/linux/netdevice.h | 3 + include/uapi/linux/ethtool_netlink.h | 22 ++ lib/Kconfig | 1 + lib/dim/net_dim.c | 144 +++++++++- net/Kconfig | 1 + net/ethtool/coalesce.c | 273 ++++++++++++++++++- 13 files changed, 681 insertions(+), 17 deletions(-)
Signature · 1 line
2.32.0.3.g01195cf9f