eliminate dependency on non-portable __SIZEOF_LONG__
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 5 repliesIn review
- v37 patches 6 repliesSuperseded
- v26 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
* rebased on latest main as previous patch was not applying cleanly anymore.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | eal: eliminate dependency on non-portable __SIZEOF_LONG__lib/ | +5 | 0 replies | |
| 2/7 | drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__drivers/ | +1 | 0 replies | |
| 3/7 | drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__drivers/ drivers/ drivers/ +3 more | +16 | 0 replies | |
| 4/7 | drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__drivers/ drivers/ | +2 | 0 replies | |
| 5/7 | drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__drivers/ drivers/ | +3 | 0 replies | |
| 6/7 | drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__drivers/ | +4 | 0 replies | |
| 7/7 | mldev: eliminate dependency on non-portable __SIZEOF_LONG__lib/ | +1 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by.
| Patch | Chaoyong He |
|---|---|
| 1/7 | |
| 2/7 | |
| 3/7 | A-b |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC:
../lib/mldev/mldev_utils_scalar.c(465): error C2065:
'__SIZEOF_LONG__': undeclared identifier
../lib/mldev/mldev_utils_scalar.c(478): error C2051:
case expression not constant
../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065:
'__SIZEOF_LONG__': undeclared identifier
../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051:
case expression not constant
Turns out that the places where __SIZEOF_LONG__ is currently being used can equally well use sizeof(long) instead.
v4:
* rebased on latest main as previous patch was not applying cleanly anymore.
v3:
* added prefix RTE_ to BITS_PER_LONG* and moved them to rte_common.h
* defined PLT_BITS_PER_LONG* in drivers/common/cnxk/roc_platform.h to avoid warnings from checkpatches.sh like:
Warning in drivers/common/cnxk/roc_bits.h:
Warning in drivers/common/cnxk/roc_ie_ot.h:
Warning in drivers/common/cnxk/roc_ie_ot_tls.h:
Use plt_ symbols instead of rte_ API in cnxk base driver
It can be seen that the same was done in the past for similar macros like PLT_CACHE_LINE_SIZE
v2:
* fixed typo in commit message
Andre Muezerie (7):
eal: eliminate dependency on non-portable __SIZEOF_LONG__ drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__ drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__ drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__ drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__ drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__
mldev: eliminate dependency on non-portable __SIZEOF_LONG__
drivers/bus/fslmc/mc/fsl_mc_cmd.h | 3 +-- drivers/common/cnxk/cnxk_security_ar.h | 4 ++-- drivers/common/cnxk/roc_bits.h | 13 ++++--------- drivers/common/cnxk/roc_ie_ot.h | 4 ++-- drivers/common/cnxk/roc_ie_ot_tls.h | 5 +++-- drivers/common/cnxk/roc_platform.h | 2 ++ drivers/common/nfp/nfp_platform.h | 8 +++----- drivers/dma/dpaa/dpaa_qdma.h | 3 +-- drivers/dma/hisilicon/hisi_dmadev.h | 3 +-- drivers/net/ena/base/ena_plat_dpdk.h | 6 ++---- drivers/net/hns3/hns3_ethdev.h | 3 +-- drivers/raw/ifpga/base/opae_osdep.h | 12 ++++-------- lib/eal/include/rte_common.h | 5 +++++ lib/mldev/mldev_utils_scalar.h | 6 +----- 14 files changed, 32 insertions(+), 45 deletions(-)
--
2.47.2.vfs.0.1