Skip to content

provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri

Andre Muezerie dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* Added __rte_experimental to the new functions.
* Added comments to the new functions.
* Moved tests to test_bitcount.c

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3eal: provide movdiri for MSVClib/eal/x86/include/rte_io.h+4 -00 replies
2/3eal: add rte ffs32 and rte ffs64 inline functionslib/eal/include/rte_bitops.h+74 -00 replies
3/3app/test: add test for rte_ffs32 and rte_ffs64 functions.app/test/test_bitcount.c+38 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri

MSVC does not support inline assembly so use movdiri intrinsic and provide abstracted rte_ffs{32,64} inline functions instead of directly using GCC built-ins.

v3:
* Added __rte_experimental to the new functions.
* Added comments to the new functions.
* Moved tests to test_bitcount.c

v2:
* Moved constants to the right side of the comparison
* Added tests for rte_ffs32 and rte_ffs64 functions

Andre Muezerie (1):
app/test: add test for rte_ffs32 and rte_ffs64 functions.

Tyler Retzlaff (2):
eal: provide movdiri for MSVC
eal: add rte ffs32 and rte ffs64 inline functions

 app/test/test_bitcount.c     | 38 ++++++++++++++++++
 lib/eal/include/rte_bitops.h | 74 ++++++++++++++++++++++++++++++++++++
 lib/eal/x86/include/rte_io.h |  4 ++
 3 files changed, 116 insertions(+)

--
2.47.2.vfs.0.1