Skip to content

enable build of lib/stack when using MSVC

Andre Muezerie dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* Isolated the additional implementation of rte_atomic128_cmp_exchange to MSVC only.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2test: disable non-C11 atomic tests for MSVCapp/test/test_atomic.c+2 -00 replies
2/2stack: enable build with MSVClib/stack/meson.build lib/stack/rte_stack_lf_c11.h+27 -63 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] enable build of lib/stack when using MSVC

MSVC does not support inline assembly, which is used by the implementation of rte_atomic128_cmp_exchange and is needed by the C11 flavor of lib/stack.

A special implementation of rte_atomic128_cmp_exchange compatible with MSVC is added to rte_stack_lf_c11.h. It uses an intrinsic function when using MSVC, and inline assembly when other compilers are used.

Existing atomic tests (which are not C11 compatible) are now skipped when using MSVC.

v3:
* Isolated the additional implementation of rte_atomic128_cmp_exchange to MSVC only.

v2:
* Added MSVC compatible implementation of rte_atomic128_cmp_exchange
* Skipped non-C11 atomic tests when using MSVC

Andre Muezerie (2):
test: disable non-C11 atomic tests for MSVC
stack: enable build with MSVC

 app/test/test_atomic.c       |  2 ++
 lib/stack/meson.build        |  6 ------
 lib/stack/rte_stack_lf_c11.h | 27 +++++++++++++++++++++++++++
 3 files changed, 29 insertions(+), 6 deletions(-)

--
2.47.2.vfs.0.1