Skip to content

enable "app" to be compiled with MSVC

Andre Muezerie dpdk-dev 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 posting 2/22 patches 4 repliesIn review
  2. v4 posting 2/21 patch 4 repliesApplied
  3. v6 Latest10 patches 4 repliesIn review
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v5 posting 1/210 patches5 repliesSuperseded
v4 posting 1/210 patches6 repliesSuperseded
v3 posting 2/26 patches2 repliesSuperseded
v3 posting 1/210 patches2 repliesSuperseded
v2 posting 2/25 patches2 repliesSuperseded
v2 posting 1/210 patches15 repliesSuperseded
v19 of 10 patches15 repliesSuperseded

Changes in v6 from the cover letter

- remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC qualified lcore_count, which is cleaner than using "volatile".

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10eal: add workaround for __builtin_constant_plib/eal/include/generic/rte_pause.h lib/eal/include/rte_common.h+34 -20 replies
2/10test_alarm: avoid warning about different qualifiersapp/test/test_alarm.c+6 -60 replies
3/10test-pmd: fix printf format string mismatchapp/test-pmd/csumonly.c+12 -110 replies
4/10test-pmd: do explicit 64-bit shift to avoid implicit conversionapp/test-pmd/cmdline.c app/test-pmd/testpmd.c app/test-pmd/util.c+4 -40 replies
5/10test-pmd: avoid undefined behaviorapp/test-pmd/cmdline.c app/test-pmd/testpmd.h+10 -42 replies
6/10test-pmd: avoid non-constant initializerapp/test-pmd/cmdline_flow.c+3 -70 replies
7/10test-pmd: don't return value from void functionapp/test-pmd/cmdline_flow.c+8 -40 replies
8/10test/test-pmd: declare lcore_count atomicapp/test/test_ring_perf.c+5 -80 replies
9/10test: add workaround for __builtin_constant_p in test_memcpy_perfapp/test/test_memcpy_perf.c+27 -270 replies
10/10app: enable app directory to be compiled with MSVCapp/meson.build app/test-pmd/meson.build+0 -50 replies

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchBruce RichardsonKonstantin AnanyevChengwen Feng
1/10
2/10
3/10
4/10A-b
5/10
6/10
7/10A-b
8/10A-b
9/10A-b
10/10A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/10] enable "app" to be compiled with MSVC

v6:
- remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC qualified lcore_count, which is cleaner than using "volatile".

v5:
- add "volatile" to declaration of lcore_count in test_ring_perf.c.

v4:
- add explanation about the expression used in __rte_constant during v3.

v3:
- use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used.
- use %u in csumonly.c and just cast variables to unsigned int.

v2:
- use lcore_count as atomic always, not only when RTE_USE_C11_MEM_MODEL is set.
- use PRIu64 in csumonly.c instead of casting variables to int.

Andre Muezerie (10):
eal: add workaround for __builtin_constant_p
test_alarm: avoid warning about different qualifiers
test-pmd: fix printf format string mismatch
test-pmd: do explicit 64-bit shift to avoid implicit conversion
test-pmd: avoid undefined behavior
test-pmd: avoid non-constant initializer
test-pmd: don't return value from void function test/test-pmd: declare lcore_count atomic
test: add workaround for __builtin_constant_p in test_memcpy_perf
app: enable app directory to be compiled with MSVC

 app/meson.build                     |  4 ---
 app/test-pmd/cmdline.c              | 16 +++++----
 app/test-pmd/cmdline_flow.c         | 22 ++++++------
 app/test-pmd/csumonly.c             | 23 ++++++------
 app/test-pmd/meson.build            |  1 -
 app/test-pmd/testpmd.c              |  2 +-
 app/test-pmd/testpmd.h              |  2 ++
 app/test-pmd/util.c                 |  2 +-
 app/test/test_alarm.c               | 12 +++----
 app/test/test_memcpy_perf.c         | 54 ++++++++++++++---------------
 app/test/test_ring_perf.c           | 13 +++----
 lib/eal/include/generic/rte_pause.h |  2 +-
 lib/eal/include/rte_common.h        | 34 +++++++++++++++++-
 13 files changed, 109 insertions(+), 78 deletions(-)

--
2.48.1.vfs.0.0