enable "app" to be compiled with MSVC
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 posting 2/22 patches 4 repliesIn review
- v4 posting 2/21 patch 4 repliesApplied
- v6 Latest10 patches 4 repliesIn review
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 1/2 | 10 patches | 5 replies | Superseded | |
| v4 posting 1/2 | 10 patches | 6 replies | Superseded | |
| v3 posting 2/2 | 6 patches | 2 replies | Superseded | |
| v3 posting 1/2 | 10 patches | 2 replies | Superseded | |
| v2 posting 2/2 | 5 patches | 2 replies | Superseded | |
| v2 posting 1/2 | 10 patches | 15 replies | Superseded | |
| v1 | 9 of 10 patches | 15 replies | Superseded |
Changes in v6 from the cover letter
- remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC qualified lcore_count, which is cleaner than using "volatile".
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | eal: add workaround for __builtin_constant_plib/ lib/ | +34 | 0 replies | |
| 2/10 | test_alarm: avoid warning about different qualifiersapp/ | +6 | 0 replies | |
| 3/10 | test-pmd: fix printf format string mismatchapp/ | +12 | 0 replies | |
| 4/10 | test-pmd: do explicit 64-bit shift to avoid implicit conversionapp/ app/ app/ | +4 | 0 replies | |
| 5/10 | test-pmd: avoid undefined behaviorapp/ app/ | +10 | 2 replies | |
| 6/10 | test-pmd: avoid non-constant initializerapp/ | +3 | 0 replies | |
| 7/10 | test-pmd: don't return value from void functionapp/ | +8 | 0 replies | |
| 8/10 | test/test-pmd: declare lcore_count atomicapp/ | +5 | 0 replies | |
| 9/10 | test: add workaround for __builtin_constant_p in test_memcpy_perfapp/ | +27 | 0 replies | |
| 10/10 | app: enable app directory to be compiled with MSVCapp/ app/ | +0 | 0 replies |
Reviews trailers per patch
5 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Richardson | Konstantin Ananyev | Chengwen Feng |
|---|---|---|---|
| 1/10 | |||
| 2/10 | |||
| 3/10 | |||
| 4/10 | A-b | ||
| 5/10 | |||
| 6/10 | |||
| 7/10 | A-b | ||
| 8/10 | A-b | ||
| 9/10 | A-b | ||
| 10/10 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 00/10] enable "app" to be compiled with MSVC
v6:
- remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC qualified lcore_count, which is cleaner than using "volatile".
v5:
- add "volatile" to declaration of lcore_count in test_ring_perf.c.
v4:
- add explanation about the expression used in __rte_constant during v3.
v3:
- use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used.
- use %u in csumonly.c and just cast variables to unsigned int.
v2:
- use lcore_count as atomic always, not only when RTE_USE_C11_MEM_MODEL is set.
- use PRIu64 in csumonly.c instead of casting variables to int.
Andre Muezerie (10):
eal: add workaround for __builtin_constant_p
test_alarm: avoid warning about different qualifiers
test-pmd: fix printf format string mismatch
test-pmd: do explicit 64-bit shift to avoid implicit conversion
test-pmd: avoid undefined behavior
test-pmd: avoid non-constant initializer
test-pmd: don't return value from void function test/test-pmd: declare lcore_count atomic
test: add workaround for __builtin_constant_p in test_memcpy_perf
app: enable app directory to be compiled with MSVC
app/meson.build | 4 --- app/test-pmd/cmdline.c | 16 +++++---- app/test-pmd/cmdline_flow.c | 22 ++++++------ app/test-pmd/csumonly.c | 23 ++++++------ app/test-pmd/meson.build | 1 - app/test-pmd/testpmd.c | 2 +- app/test-pmd/testpmd.h | 2 ++ app/test-pmd/util.c | 2 +- app/test/test_alarm.c | 12 +++---- app/test/test_memcpy_perf.c | 54 ++++++++++++++--------------- app/test/test_ring_perf.c | 13 +++---- lib/eal/include/generic/rte_pause.h | 2 +- lib/eal/include/rte_common.h | 34 +++++++++++++++++- 13 files changed, 109 insertions(+), 78 deletions(-)
--
2.48.1.vfs.0.0