Skip to content

fix how large numbers are printed by hash tests

Andre Muezerie dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v43 patches 2 repliesSuperseded
  3. v33 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v23 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Rebased and updated to conform to new function versioning mechanism.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3eal: add function rte_size_to_strlib/eal/common/eal_common_string_fns.c lib/eal/include/rte_common.h+88 -00 replies
2/3hash_multiwriter_autotest: fix printf parametersapp/test/test_hash_multiwriter.c+11 -30 replies
3/3hash_readwrite_autotest: fix printf parametersapp/test/test_hash_readwrite.c+12 -20 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMorten Brørup
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] fix how large numbers are printed by hash tests

v5:
- Rebased and updated to conform to new function versioning mechanism.

v4:
- Added parameter "unit", which allows rte_size_to_str() to be smarter about the need to append a space after the number. This keeps the function easy to use and avoids the need for complex explanations about the space that could be needed between number and multiple/unit.
- Changed the return type of rte_size_to_str() to be buf, or NULL on error, allowing the function to be inlined.
- Removed a line wrap.

v3:
- Added rte_size_to_str to version.map (marked experimental for 25.07) so that symbol gets exported when building with -Ddefault_library=shared
- Added sample outputs
- Added a space between the number and the postfix (if a postfix is present)

Andre Muezerie (3):
eal: add function rte_size_to_str
hash_multiwriter_autotest: fix printf parameters
hash_readwrite_autotest: fix printf parameters

 app/test/test_hash_multiwriter.c       | 14 +++++--
 app/test/test_hash_readwrite.c         | 14 ++++++-
 lib/eal/common/eal_common_string_fns.c | 54 ++++++++++++++++++++++++++
 lib/eal/include/rte_common.h           | 34 ++++++++++++++++
 4 files changed, 111 insertions(+), 5 deletions(-)

--
2.49.0.vfs.0.0