Skip to content

net: mana: Add HTB Qdisc offload support

Erni Sri Satya Vennela linux-hyperv linux-rdma lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* Use -EOPNOTSUPP instead of -EPROTO in mana_query_link_cfg() and mana_set_bw_clamp()
* Change link_speed to link_speed_mbps in struct mana_set_bw_clamp_req.
---
Erni Sri Satya Vennela (3):
net: mana: Add speed support in mana_get_link_ksettings
net: mana: Add sched HTB offload support
net: mana: Handle unsupported HWC commands

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: mana: Add speed support in mana_get_link_ksettingsdrivers/net/ethernet/microsoft/mana/mana_en.c drivers/net/ethernet/microsoft/mana/mana_ethtool.c include/net/mana/mana.h+65 -02 replies
2/3net: mana: Add sched HTB offload supportdrivers/net/ethernet/microsoft/mana/mana_en.c include/net/mana/mana.h+157 -05 replies
3/3net: mana: Handle unsupported HWC commandsdrivers/net/ethernet/microsoft/mana/hw_channel.c drivers/net/ethernet/microsoft/mana/mana_en.c+15 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchShradha GuptaHaiyang Zhang
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] net: mana: Add HTB Qdisc offload support

Introduce support for HTB Qdisc offload on the mana ethernet controller to enable bandwidth clamping for egress traffic.

The controller offloads only one HTB leaf to support bandwidth clamping on the hardware. This involves calling the function mana_set_bw_clamp() which internally calls a HWC command to the hardware to set the speed.

The minimum supported bandwidth is 100 Mbps, and only multiples of 100 Mbps are supported by the hardware. The speed will be reset to maximum bandwidth supported by the SKU, when the HTB leaf is deleted.

Also add speed support in mana_get_link_ksettings to display speed in the standard port information using ethtool. This involves calling mana_query_link_config(), which internally sends a HWC command to the hardware to query speed information.

Note that this feature is not supported by all hardware.

---
Changes in v2:
* Use -EOPNOTSUPP instead of -EPROTO in mana_query_link_cfg() and mana_set_bw_clamp()
* Change link_speed to link_speed_mbps in struct mana_set_bw_clamp_req.
---
Erni Sri Satya Vennela (3):
net: mana: Add speed support in mana_get_link_ksettings
net: mana: Add sched HTB offload support
net: mana: Handle unsupported HWC commands

 .../net/ethernet/microsoft/mana/hw_channel.c  |   4 +
 drivers/net/ethernet/microsoft/mana/mana_en.c | 191 ++++++++++++++++++
 .../ethernet/microsoft/mana/mana_ethtool.c    |   6 +
 include/net/mana/mana.h                       |  36 ++++
 4 files changed, 237 insertions(+)
Signature · 1 line
2.34.1