Skip to content

RFC devlink: Add unique identifier to devlink port function

Moshe Shemesh netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5devlink: Add unique identifier to devlink port functionDocumentation/netlink/specs/devlink.yaml Documentation/networking/devlink/devlink-port.rst include/net/devlink.h +2 more+56 -02 replies
2/5net/mlx5: Move mlx5_cmd_query_vuid() from IB to coredrivers/infiniband/hw/mlx5/cmd.c drivers/infiniband/hw/mlx5/cmd.h drivers/infiniband/hw/mlx5/main.c +2 more+25 -240 replies
3/5net/mlx5: Add vhca_id argument to mlx5_core_query_vuid()drivers/infiniband/hw/mlx5/main.c drivers/net/ethernet/mellanox/mlx5/core/fw.c include/linux/mlx5/driver.h+7 -60 replies
4/5net/mlx5: Add define for max VUID string sizedrivers/infiniband/hw/mlx5/main.c include/linux/mlx5/driver.h+2 -10 replies
5/5net/mlx5: Expose unique identifier in devlink port functiondrivers/net/ethernet/mellanox/mlx5/core/esw/devlink_port.c drivers/net/ethernet/mellanox/mlx5/core/eswitch.h drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c+38 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC net-next 0/5] devlink: Add unique identifier to devlink port function

A function unique identifier (UID) is a vendor defined string of arbitrary length that universally identifies a function. The function UID can be reported by device drivers via devlink dev info command.

This patch set adds UID attribute to devlink port function that reports the UID of the function that pertains to the devlink port. Code is also added to mlx5 as the first user to implement this attribute.

The main purpose of adding this attribute is to allow users to unambiguously map between a function and the devlink port that manages it, which might be on another host.

For example, one can retrieve the UID of a function using the "devlink dev info" command and then search for the same UID in the output of "devlink port show" command.

The "devlink dev info" support for UID of a function is added by a separate patchset [1]. This patchset is submitted as an RFC to illustrate the other side of the solution.

Other existing identifiers such as serial_number or board.serial_number are not good enough as they don't guarantee uniqueness per function. For example, in a multi-host NIC all PFs report the same value.

Example output:

$ devlink port show pci/0000:03:00.0/327680 -jp
{
    "port": {
        "pci/0000:03:00.0/327680": {
            "type": "eth",
            "netdev": "pf0hpf",
            "flavour": "pcipf",
            "controller": 1,
            "pfnum": 0,
            "external": true,
            "splittable": false,
            "function": {
                "hw_addr": "5c:25:73:37:70:5a",
                "roce": "enable",
                "max_io_eqs": 120,
                "uid":
"C6A76AD20605BE026D23C14E70B90704F4A5F5B3F304D83B37000732BF861D48MLNXS0D0F0"
            }
        }
    }
}

[1] https://lore.kernel.org/netdev/[email protected]/

Avihai Horon (5):
devlink: Add unique identifier to devlink port function net/mlx5: Move mlx5_cmd_query_vuid() from IB to core net/mlx5: Add vhca_id argument to mlx5_core_query_vuid() net/mlx5: Add define for max VUID string size net/mlx5: Expose unique identifier in devlink port function

 Documentation/netlink/specs/devlink.yaml      |  3 ++
 .../networking/devlink/devlink-port.rst       | 12 +++++++
 drivers/infiniband/hw/mlx5/cmd.c              | 21 ------------
 drivers/infiniband/hw/mlx5/cmd.h              |  2 --
 drivers/infiniband/hw/mlx5/main.c             |  5 +--
 .../mellanox/mlx5/core/esw/devlink_port.c     |  2 ++
 .../net/ethernet/mellanox/mlx5/core/eswitch.h |  2 ++
 .../mellanox/mlx5/core/eswitch_offloads.c     | 34 +++++++++++++++++++
 drivers/net/ethernet/mellanox/mlx5/core/fw.c  | 22 ++++++++++++
 include/linux/mlx5/driver.h                   |  3 ++
 include/net/devlink.h                         |  8 +++++
 include/uapi/linux/devlink.h                  |  1 +
 net/devlink/port.c                            | 32 +++++++++++++++++
 13 files changed, 122 insertions(+), 25 deletions(-)
Signature · 1 line
2.27.0