Support bandwidth clamping in mana using net shapers
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyApplied 4/4
- v24 patches 4 repliesSuperseded
- v14 patches 6 repliesSuperseded
Changes in v3 from the cover letter
* Rebase to latest net-next branch.
Patches in v3 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net: mana: Fix potential deadlocks in mana napi opsdrivers/ | +19 | 0 replies | Applied |
| 2/4 | net: mana: Add support for net_shaper_opsdrivers/ include/ | +195 | 0 replies | Applied |
| 3/4 | net: mana: Add speed support in mana_get_link_ksettingsdrivers/ drivers/ include/ | +9 | 1 reply | Applied |
| 4/4 | net: mana: Handle unsupported HWC commandsdrivers/ drivers/ include/ | +16 | 0 replies | Applied |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Haiyang Zhang | Shradha Gupta | Saurabh Singh Sengar | Long Li | Dipayaan Roy |
|---|---|---|---|---|---|
| 1/4 | R-b | R-b | R-b | R-b | |
| 2/4 | R-b | R-b | R-b | R-b | |
| 3/4 | R-b | R-b | R-b | R-b | |
| 4/4 | R-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH net-next v3 0/4] Support bandwidth clamping in mana using net shapers
This patchset introduces hardware-backed bandwidth rate limiting for MANA NICs via the net_shaper_ops interface, enabling efficient and fine-grained traffic shaping directly on the device.
Previously, MANA lacked a mechanism for user-configurable bandwidth control. With this addition, users can now configure shaping parameters, allowing better traffic management and performance isolation.
The implementation includes the net_shaper_ops callbacks in the MANA driver and supports one shaper per vport. Add shaping support via mana_set_bw_clamp(), allowing the configuration of bandwidth rates in 100 Mbps increments (minimum 100 Mbps). The driver validates input and rejects unsupported values. On failure, it restores the previous configuration which is queried using mana_query_link_cfg() or retains the current state.
To prevent potential deadlocks introduced by net_shaper_ops, switch to _locked variants of NAPI APIs when netdevops_lock is held during VF setup and teardown.
Also, Add support for ethtool get_link_ksettings to report the maximum link speed supported by the SKU in mbps.
These APIs when invoked on hardware that are older or that do not support these APIs, the speed would be reported as UNKNOWN and the net-shaper calls to set speed would fail.
---
Changes in v3:
* Rebase to latest net-next branch.
Changes in v2:
* Rebase to latest net-next branch.
* Edit commit message in
"net: mana: Fix potential deadlocks in mana napi ops".
* Use netdev_lock_ops_to_full() instead of explicit if..else statements for napi APIs.
* Define GDMA_STATUS_CMD_UNSUPPORTED for unsupported HWC status code.
---
Erni Sri Satya Vennela (4):
net: mana: Fix potential deadlocks in mana napi ops
net: mana: Add support for net_shaper_ops
net: mana: Add speed support in mana_get_link_ksettings
net: mana: Handle unsupported HWC commands
.../net/ethernet/microsoft/mana/hw_channel.c | 4 + drivers/net/ethernet/microsoft/mana/mana_en.c | 195 +++++++++++++++++- .../ethernet/microsoft/mana/mana_ethtool.c | 6 + include/net/mana/gdma.h | 1 + include/net/mana/mana.h | 42 ++++ 5 files changed, 239 insertions(+), 9 deletions(-)
Signature · 1 line
2.34.1