Skip to content

net/mlx5e: Add support for PCIe congestion events

Tariq Toukan linux-doc linux-rdma lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesApplied 2/2
  2. v23 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Dropped sysfs configuration patch.
- Fixed compilation issue when !CONFIG_MLX5_CORE_EN.
- Updated cover letter description.

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net/mlx5e: Create/destroy PCIe Congestion Event objectdrivers/net/ethernet/mellanox/mlx5/core/Makefile drivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c +3 more+169 -10 repliesApplied
2/2net/mlx5e: Add device PCIe congestion ethtool statsDocumentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +2 more+212 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next V3 0/2] net/mlx5e: Add support for PCIe congestion events

Hi,

This is V3. Find V2 here:
https://lore.kernel.org/all/[email protected]/

Find detailed feature description by Dragos below [1].

Regards,
Tariq

V3:
- Dropped sysfs configuration patch.
- Fixed compilation issue when !CONFIG_MLX5_CORE_EN.
- Updated cover letter description.

V2:
- Rebase on top of the IFC patches, they got pulled through mlx5-next.

[1]
PCIe congestion events are events generated by the firmware when the device side has sustained PCIe inbound or outbound traffic above certain thresholds. The high and low threshold are hysteresis thresholds to prevent flapping: once the high threshold has been reached, a low threshold event will be triggered only after the bandwidth usage went below the low threshold.

This series adds support for receiving and exposing such events as ethtool counters.

2 new pairs of counters are exposed: pci_bw_in/outbound_high/low. These should help the user understand if the device PCI is under pressure.

Planned followup patches:
- Allow configuration of thresholds through devlink.
- Add ethtool counter for wakeups which did not result in any state change.

Dragos Tatulea (2):
net/mlx5e: Create/destroy PCIe Congestion Event object net/mlx5e: Add device PCIe congestion ethtool stats

 .../ethernet/mellanox/mlx5/counters.rst       |  32 ++
 .../net/ethernet/mellanox/mlx5/core/Makefile  |   2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en.h  |   2 +
 .../mellanox/mlx5/core/en/pcie_cong_event.c   | 315 ++++++++++++++++++
 .../mellanox/mlx5/core/en/pcie_cong_event.h   |  10 +
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   3 +
 .../ethernet/mellanox/mlx5/core/en_stats.c    |   1 +
 .../ethernet/mellanox/mlx5/core/en_stats.h    |   1 +
 drivers/net/ethernet/mellanox/mlx5/core/eq.c  |   3 +
 .../ethernet/mellanox/mlx5/core/mlx5_core.h   |  13 +
 10 files changed, 381 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.h

base-commit: 06baf9bfa6ca8db7d5f32e12e27d1dc1b7cb3a8a

Signature · 1 line
2.31.1