Introduce and use netif_xmit_timeout_ms() helper
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 2 repliesApplied 3/3
- v13 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Rebase.
- Move helper to include/net/netdev_queues.h.
- Remove output paramter trans_start from the new helper.
- Revert the code in dev_watchdog to not use the helper.
- Fix the helper name in commit message.
Patches in v2 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: Introduce netif_xmit_timeout_ms() helperinclude/ | +11 | 0 replies | Applied |
| 2/3 | net: hns3: Use netif_xmit_timeout_ms() helperdrivers/ | +5 | 1 reply | Applied |
| 3/3 | net/mlx5e: Refine TX timeout handling to skip non-timed-out SQdrivers/ | +1 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Yael Chemla | Jijie Shao | Simon Horman |
|---|---|---|---|
| Series | R-b | ||
| 1/3 | R-b | ||
| 2/3 | R-b | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net-next V2 0/3] Introduce and use netif_xmit_timeout_ms() helper
Hi,
This is V2, find V1 here:
https://lore.kernel.org/all/[email protected]/
This series by Shahar introduces a new helper function netif_xmit_timeout_ms() to check if a TX queue has timed out and report the timeout duration.
It also encapsulates the check for whether the TX queue is stopped.
Replace duplicated open-coded timeout check in hns3 driver with the new helper.
For mlx5e, refine the TX timeout recovery flow to act only on SQs whose transmit timestamp indicates an actual timeout, as determined by the helper. This prevents unnecessary channel reopen events caused by attempting recovery on queues that are merely stopped but not truly timed out.
Regards,
Tariq
V2:
- Rebase.
- Move helper to include/net/netdev_queues.h.
- Remove output paramter trans_start from the new helper.
- Revert the code in dev_watchdog to not use the helper.
- Fix the helper name in commit message.
Shahar Shitrit (3):
net: Introduce netif_xmit_timeout_ms() helper
net: hns3: Use netif_xmit_timeout_ms() helper net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++++------- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- include/net/netdev_queues.h | 11 +++++++++++ 3 files changed, 17 insertions(+), 8 deletions(-)
base-commit: 60d8484c4cec811f5ceb6550655df74490d1a165
Signature · 1 line
2.31.1