Skip to content

tracing/probes: Add more typecast features

Masami Hiramatsu (Google) linux-doc linux-kselftest linux-trace-kernel lkml 14 versions – In review

Get series with b4
b4 am 178271357142.1176915.7193483024740701480.stgit@devnote2

Versions newest first · linked by author and title

  1. v13 Latest11 patches 4 repliesIn review
  2. v1211 patches 0 repliesSuperseded
  3. v1111 patches 1 replySuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v109 patches1 replySuperseded
v99 patches0 repliesSuperseded
v810 patches1 replySuperseded
v710 patches4 repliesSuperseded
v6 posting 2/28 patches0 repliesSuperseded
v6 posting 1/28 patches1 replySuperseded
v57 patches1 replySuperseded
v47 patches1 replySuperseded
v37 patches0 repliesSuperseded
v2 RFC7 patches0 repliesSuperseded
v1 RFC7 patches1 replySuperseded

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11tracing/probes: Allow eprobe to use variable without $ prefixkernel/trace/trace_probe.c kernel/trace/trace_probe.h tools/testing/selftests/ftrace/test.d/dynevent/eprobes_syntax_errors.tc+13 -30 replies
2/11tracing/probes: Support dumping fetcharg program for debugging dynamic eventskernel/trace/Kconfig kernel/trace/trace_eprobe.c kernel/trace/trace_fprobe.c +4 more+164 -320 replies
3/11tools/bootconfig: Ignore comment lines in dynamic_events/kprobe_events filetools/bootconfig/scripts/ftrace2bconf.sh+2 -00 replies
4/11perf/probe: Ignore comment lines in dynamic_events/kprobe_events filetools/perf/util/probe-file.c+2 -04 replies
5/11tracing/probes: Support typecast for various probe eventsDocumentation/trace/fprobetrace.rst Documentation/trace/kprobetrace.rst kernel/trace/trace.c +2 more+30 -70 replies
6/11tracing/probes: Support nested typecastDocumentation/trace/eprobetrace.rst Documentation/trace/fprobetrace.rst Documentation/trace/kprobetrace.rst +3 more+88 -90 replies
7/11tracing/probes: Type casting always involves nested callskernel/trace/trace_probe.c kernel/trace/trace_probe.h+75 -520 replies
8/11tracing/probes: Support field specifier option for typecastDocumentation/trace/eprobetrace.rst Documentation/trace/fprobetrace.rst Documentation/trace/kprobetrace.rst +3 more+135 -640 replies
9/11tracing/probes: Add $current variable supportDocumentation/trace/fprobetrace.rst Documentation/trace/kprobetrace.rst kernel/trace/trace.c +3 more+44 -30 replies
10/11tracing/probes: Add this_cpu_read() and this_cpu_ptr() dereference method to fetchargDocumentation/trace/fprobetrace.rst Documentation/trace/kprobetrace.rst kernel/trace/trace.c +3 more+138 -450 replies
11/11tracing/probes: Add a new testcase for BTF typecastssamples/trace_events/trace-events-sample.c samples/trace_events/trace-events-sample.h tools/testing/selftests/ftrace/test.d/dynevent/btf_probe_event.tc +5 more+261 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v13 yet.

Read the v13 thread

Cover letter [PATCH v13 00/11] tracing/probes: Add more typecast features

Hi,

Here is the 13th version of series to introduce more typecast features to probe events. The previous version is here:

https://lore.kernel.org/all/178269068329.1161310.17763177188897860801.stgit@devnote2/

This version fixes a missed comma issue [8/11][10/11] pointed by Sashiko.

This series extends BTF typecast feature and add more options:

1. Expanding BTF typecast to kprobe and fprobe.
(currently only function entry/exit)

2. Introduce container_of like typecast. This adds a "assigned member" option to the typecast.

(STRUCT,MEMBER)VAR->ANOTHER_MEMBER

This casts VAR to STRUCT type but the VAR is as the address of STRUCT.MEMBER. In C, it is:

container_of(VAR, STRUCT, MEMBER)->ANOTHER_MEMBER

3. Support nested typecast, e.g.

(STRUCT)((STRUCT2)VAR->MEMBER2)->MEMBER

the nest level must be smaller than 3.

4. Add $current variable to point "current" task_struct. This is useful with typecast, e.g.

(task_struct)$current->pid

5. per-cpu dereference support.

Intrdouce this_cpu_read(VAR) and this_cpu_ptr(VAR) to access per-cpu data on the current CPU (accessing other CPU data is not stable, because it can be changed.)

You can access the member of per-cpu data structure using typecast like:

(STRUCT)this_cpu_ptr(VAR)->MEMBER

6. Support event fields without $ prefix on eprobes.

Now eprobe events can access its event fields.

And added fetcharg dump feature (for debug) and updated test scripts to test part of them.

Thanks,

---
base-commit: c69b5f959286395e94c237ce6d7d4970bad7f6e3

Masami Hiramatsu (Google) (11):
tracing/probes: Allow eprobe to use variable without $ prefix tracing/probes: Support dumping fetcharg program for debugging dynamic events tools/bootconfig: Ignore comment lines in dynamic_events/kprobe_events file perf/probe: Ignore comment lines in dynamic_events/kprobe_events file tracing/probes: Support typecast for various probe events tracing/probes: Support nested typecast
tracing/probes: Type casting always involves nested calls tracing/probes: Support field specifier option for typecast tracing/probes: Add $current variable support
tracing/probes: Add this_cpu_read() and this_cpu_ptr() dereference method to fetcharg tracing/probes: Add a new testcase for BTF typecasts

 Documentation/trace/eprobetrace.rst                |    7 
 Documentation/trace/fprobetrace.rst                |   10 
 Documentation/trace/kprobetrace.rst                |   11 
 kernel/trace/Kconfig                               |   12 
 kernel/trace/trace.c                               |    8 
 kernel/trace/trace_eprobe.c                        |    2 
 kernel/trace/trace_fprobe.c                        |    2 
 kernel/trace/trace_kprobe.c                        |    2 
 kernel/trace/trace_probe.c                         |  585 ++++++++++++++++----
 kernel/trace/trace_probe.h                         |  100 ++-
 kernel/trace/trace_probe_tmpl.h                    |   25 +
 kernel/trace/trace_uprobe.c                        |    3 
 samples/trace_events/trace-events-sample.c         |   40 +
 samples/trace_events/trace-events-sample.h         |   34 +
 tools/bootconfig/scripts/ftrace2bconf.sh           |    2 
 tools/perf/util/probe-file.c                       |    2 
 .../ftrace/test.d/dynevent/btf_probe_event.tc      |   51 ++
 .../test.d/dynevent/btf_typecast_accepted.tc       |  103 ++++
 .../test.d/dynevent/eprobes_syntax_errors.tc       |   12 
 .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc |   12 
 .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc   |   12 
 .../ftrace/test.d/kprobe/uprobe_syntax_errors.tc   |    5 
 22 files changed, 886 insertions(+), 154 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/btf_probe_event.tc
 create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/btf_typecast_accepted.tc

--
Masami Hiramatsu (Google) <[email protected]>