Skip to content

tracing/probes: Clean up and refactor argument parser

Masami Hiramatsu (Google) linux-kselftest linux-trace-kernel lkml 1 version In review

Get series with b4
b4 am 178386876526.3174487.5142283230157728964.stgit@devnote2

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tracing/probes: Refactor parse_probe_vars()kernel/trace/trace_probe.c+151 -970 replies
2/5tracing/probes: Refactor parse_probe_arg()kernel/trace/trace_probe.c+174 -1260 replies
3/5tracing/probes: Sort ERRORS list in trace_probe.h alphabeticallykernel/trace/trace_probe.h+80 -800 replies
4/5tracing/probes: Extend max length of argument stringkernel/trace/trace_fprobe.c kernel/trace/trace_kprobe.c kernel/trace/trace_probe.h +4 more+8 -71 reply
5/5tracing/probes: Eliminate recursion in parse_probe_arg()kernel/trace/trace_probe.c kernel/trace/trace_probe.h tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc +2 more+243 -1370 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] tracing/probes: Clean up and refactor argument parser

Hi,

This series refactors and cleans up the fetcharg parser in the trace_probe. The main goals are to improve code readability, prevent kernel stack overflow by eliminating recursive function calls, and extend the argument string length limit to support complex BTF typecast expressions.

Previously, parse_probe_arg() recursively called itself when parsing nested dereferences and typecasts. Since the kernel stack is limited, deep recursion is undesirable. The [5/5] eliminates the recursion by converting the nested argument parsing into a loop-based implementation utilizing a parse state stack. To prepare it, the [1/5] and [2/5] cleanup (decompose) the parser functions.

Additionally, this series increases the maximum nesting depth from 3 to 4, extends the argument length limit from 63 to 256 and updates the associated ftrace syntax error selftests.

Patches:
- Patch 1: Decomposes parse_probe_vars() into smaller, dedicated helper functions for parsing specific variable types ($retval, $stack, etc.).
- Patch 2: Decomposes parse_probe_arg() into static helper subroutines for handling registers, memory/symbols, and immediates.
- Patch 3: Alphabetizes the ERRORS macros list in trace_probe.h to improve readability.
- Patch 4: Extends MAX_ARGSTR_LEN from 63 to 256 for long BTF cast/dereference arguments, and introduces MAX_COMMON_HEAD_LEN to prevent regression on match head commands.
- Patch 5: Eliminates recursion in parse_probe_arg() using a loop and a parse state stack integrated into traceprobe_parse_context. It also raises the nesting limit to 4 and updates the selftest scripts.

Thanks,

---

Masami Hiramatsu (5):
tracing/probes: Refactor parse_probe_vars() tracing/probes: Refactor parse_probe_arg() tracing/probes: Sort ERRORS list in trace_probe.h alphabetically tracing/probes: Extend max length of argument string tracing/probes: Eliminate recursion in parse_probe_arg()

 kernel/trace/trace_fprobe.c                        |    2 
 kernel/trace/trace_kprobe.c                        |    2 
 kernel/trace/trace_probe.c                         |  843 ++++++++++++--------
 kernel/trace/trace_probe.h                         |  196 +++--
 kernel/trace/trace_uprobe.c                        |    2 
 .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc |    6 
 .../ftrace/test.d/dynevent/tprobe_syntax_errors.tc |    4 
 .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc   |    6 
 8 files changed, 635 insertions(+), 426 deletions(-)

--
Masami Hiramatsu (Google) <[email protected]>