Skip to content

Fix for RSP vCont packet

Lucien Anti-Spam qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1Fix for RSP vCont packetgdbstub.cindex bfc7afb509..ce0dde2e24 100644--- a/gdbstub.c+++ b/gdbstub.c@@ -1169,6 +1169,7 @@ static int is_query_packet(const char *p, const char *query, char separator)  */ static int gdb_handle_vcont(GDBState *s, const char *p) {+    GDBThreadIdKind vcontThreadType ;     int res, signal = 0;     char cur_action;     char *newstates;@@ -1218,12 +1219,23 @@ static int gdb_handle_vcont(GDBState *s, const char *p)             goto out;         } -        if (*p++ != ':') {+        /*+         * In the case we have vCont;c or vCont;s - action is on all threads+         * Alternatively vCont;c;s:p1.1 is a possible, but meaningless format,+         * And in the else the "vCont;c:p1.1;... format is supported.+         */+        if (*p == '\0' || *p == ';') {+            vcontThreadType = GDB_ALL_THREADS ;+            pid = 1 ;+            tid = 1 ;+        } else if (*p++ == ':') {+            vcontThreadType = read_thread_id(p, &p, &pid, &tid) ;+        } else {             res = -ENOTSUP;             goto out;         } -        switch (read_thread_id(p, &p, &pid, &tid)) {+        switch (vcontThreadType) {         case GDB_READ_THREAD_ERR:             res = -EINVAL;             goto out;-- 2.17.2+0 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread