Skip to content

Impedance matcher for Samsung boards

Tomasz Figa linux-arm-kernel 1 version New

Get series with b4
b4 am 1837099.JIoGixjT73@amdc1227

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] Impedance matcher for Samsung boards

Hi Daniel,

Quoted 32 lines · On Wednesday 11 of December 2013 15:10:39 Daniel Mack wrote:
Quoted 24 lines · Piotr Wilczek

Hi,

Quoted 22 lines

-----Original Message----- From: Daniel Mack [mailto:zonque at gmail.com] Sent: Wednesday, December 11, 2013 2:17 PM To: Piotr Wilczek; devicetree-discuss at lists.ozlabs.org; linux-arm- kernel at lists.infradead.org Cc: Jason Cooper; Nicolas Pitre Subject: Re: [PATCH 0/8] Impedance matcher for Samsung boards

Quoted 8 lines · Piotr Wilczek

This patchset implements the impedance-matcher for Samsung Exynos boards and does the following: - fix strncmp function; - ensure each DT blob is 4-byte aligned; - port 'atags_to_fdt' form Kernel; - add Exynos specific serial driver; - add support for Samsung boards, Trats and Trats2;

This patch set is based on:
https://github.com/zonque/pxa-impedance-matcher.git

Thanks for the patches!

I'm considering merging most of them, but I have my problems with the inclusion of the libfdt library.

Quoted 6 lines
Quoted 3 lines

Could you explain what you need this for, exactly? Why can't you just fix the device tree blob that you include instead of modifying it at runtime?

When bootloader needs to pass some information in ATAGS and CONFIG_ARM_APPENDED_DTB is turned off in kernel, then it has to be added to the device tree blob at runtime.

Quoted 6 lines

The question is: can't you just provide a dtb for each of your machines, and distinguish them via their machine ID? Or do you really have machines that come up with the same machine ID but differ in details only stored in ATAGs?

After all, adding libfdt makes the code grow by more than factor 4.

There are some parameters that bootloaders normally pass with ATAGS and can't be hardcoded in DT, such as initrd location in memory, serial number, board revision, command line and in some cases even memory, as on some boards it might vary between units.

Since impedance matches can't forward the ATAGs to the kernel, when the kernel doesn't boot in appended DTB mode, there is a need to inject these data into DT in the matches itself, based on ATAGs it gets from the firmware.

Best regards,
Tomasz