ACPI: Get rid of the list of children in struct acpi_device
Status from this message: Applied, thanks.
Get series with b4
b4 am 2653857.mvXUDI8C0e@kreacherVersions newest first · linked by author and title
- v2 Latest16 patches 18 repliesApplied
- v116 patches 25 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | ACPI: glue: Use acpi_dev_for_each_child()drivers/ | +63 | 0 replies | |
| 2/16 | ACPI: glue: Introduce acpi_dev_has_children()drivers/ | +11 | 0 replies | |
| 3/16 | ACPI: glue: Introduce acpi_find_child_by_adr()drivers/ include/ | +26 | 0 replies | |
| 4/16 | thunderbolt: ACPI: Replace tb_acpi_find_port() with acpi_find_child_by_adr()drivers/ | +4 | 6 replies | |
| 5/16 | USB: ACPI: Replace usb_acpi_find_port() with acpi_find_child_by_adr()drivers/ | +1 | 2 replies | |
| 6/16 | ACPI: container: Use acpi_dev_for_each_child()drivers/ | +9 | 0 replies | |
| 7/16 | ACPI: property: Use acpi_dev_for_each_child() for child lookupdrivers/ | +25 | 0 replies | |
| 8/16 | ACPI: bus: Export acpi_dev_for_each_child() to modulesdrivers/ | +1 | 0 replies | |
| 9/16 | ACPI: video: Use acpi_dev_for_each_child()drivers/ | +16 | 0 replies | |
| 10/16 | ACPI: bus: Introduce acpi_dev_for_each_child_reverse()drivers/ include/ | +15 | 0 replies | |
| 11/16 | ACPI: scan: Walk ACPI device's children using driver coredrivers/ | +29 | 0 replies | |
| 12/16 | platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child()drivers/ | +27 | 2 replies | |
| 13/16 | mfd: core: Use acpi_dev_for_each_child()drivers/ | +24 | 4 replies | |
| 14/16 | soundwire: Use acpi_dev_for_each_child()drivers/ | +67 | 4 replies | |
| 15/16 | ACPI / MMC: PM: Unify fixing up device powerdrivers/ drivers/ drivers/ +1 more | +28 | 0 replies | |
| 16/16 | ACPI: bus: Drop unused list heads from struct acpi_devicedrivers/ include/ | +1 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Pierre-Louis Bossart | Andy Shevchenko | Adrian Hunter | Ulf Hansson | Hans de Goede | Mika Westerberg | Heikki Krogerus | Vinod Koul |
|---|---|---|---|---|---|---|---|---|
| 1/16 | R-b | |||||||
| 2/16 | R-b | |||||||
| 3/16 | R-b | |||||||
| 4/16 | R-b | A-b | R-b | |||||
| 5/16 | R-b | R-b | ||||||
| 6/16 | R-b | |||||||
| 7/16 | R-b | |||||||
| 8/16 | R-b | |||||||
| 9/16 | R-b | |||||||
| 10/16 | R-b | |||||||
| 11/16 | R-b | |||||||
| 12/16 | R-b | R-b | ||||||
| 13/16 | R-b | |||||||
| 14/16 | R-b T-b | A-b | ||||||
| 15/16 | R-b | A-b | A-b | |||||
| 16/16 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.
Cover letter [PATCH v2 00/16] ACPI: Get rid of the list of children in struct acpi_device
Quoted 16 lines · CEST Rafael J. Wysocki
Hi All,
Confusingly enough, the ACPI subsystem stores the information on the given ACPI device's children in two places: as the list of children in struct
acpi_deviceand (as a result of device registration) in the list of children in the embedded struct device.These two lists agree with each other most of the time, but not always (like in error paths in some cases), and the list of children in struct
acpi_deviceis not generally safe to use without locking. In principle, it should always be walked underacpi_device_lock, but in practice holdingacpi_scan_lockis sufficient for that too. However, its users may not know whether or not they operate underacpi_scan_lockand at least in some cases it is not accessed in a safe way (note that ACPI devices may go away as a result of hot-remove, unlike OF nodes).
Quoted 8 lines
For this reason, it is better to consolidate the code that needs to walk the children of an ACPI device which is the purpose of this patch series.
Overall, it switches over all of the users of the list of children in struct
acpi_deviceto using helpers based on the driver core's mechanics and finally drops that list, but some extra cleanups are done on the way.Please refer to the patch changelogs for details.
Here's a v2 of this series, mostly addressing review comments, but the subjects of the Thunderbolt and USB patches have been changed too.
Thanks!