Skip to content

ACPI: Install notify or event handlers in ACPI button drivers

Rafael J. Wysocki linux-acpi lkml 1 version In review

Get series with b4
b4 am 1847933.atdPhlSkOF@kreacher

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ACPI: button: Eliminate the driver notify callbackdrivers/acpi/button.c+96 -441 reply
2/4ACPI: button: Use different notify handlers for lid and buttonsdrivers/acpi/button.c+24 -90 replies
3/4ACPI: tiny-power-button: Eliminate the driver notify callbackdrivers/acpi/tiny-power-button.c+41 -80 replies
4/4ACPI: bus: Simplify installation and removal of notify callbackdrivers/acpi/bus.c+9 -440 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchMichal Wilczynski
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFT][PATCH v1 0/4] ACPI: Install notify or event handlers in ACPI button drivers

Hi Folks,

This series reworks the two ACPI button drivers to install notify or fixed event handlers (depending on the device type) by themselves, so the core code need not take the "fixed event handler for a button driver" case in the general driver notify handler installer.

As a bonus, it separates the notify handler in the "generic" button driver into a lid notify handler and a proper button notify handler.

It modifies also the core to drop the "fixed event handler for a button driver" case from there (last patch).

It works for me, but I would appreciate as much testing of this as possible especially on old hardware.

Obviously, it replaces

https://lore.kernel.org/linux-acpi/4500594.LvFx2qVVIh@kreacher/T/#m064d4130b57cbcb0ece1bb415fae1465ebc20f42

and its followers to some extent, but I think that it's better to deal with the special case first and then take care of the rest.

Thanks!