Skip to content

scsi: ufs: wb: Add sysfs attribute and cleanup

Jinyoung CHOI linux-scsi lkml 7 versions – Applied

Status from this message: Applied to 6.1/scsi-staging, thanks!

Get series with b4
b4 am 20220804074224epcms2p18f0ac2f92073aeed981718a9cab23866@epcms2p1

Versions newest first · linked by author and title

  1. v7 Latest6 patches 1 replyApplied
  2. v66 patches 10 repliesSuperseded
  3. v56 patches 10 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v47 patches8 repliesSuperseded
v32 patches5 repliesSuperseded
v21 patch1 replySuperseded
v11 patch6 repliesSuperseded

Changes in v7 from the cover letter

- renaming sysfs attribute name
(wb_buf_flush_en -> enable_wb_buf_flush)
- update document description
- change debug message level (info -> dbg) (5.19/scsi-fixes, https://git.kernel.org/mkp/scsi/c/2ae57c995003)

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/6scsi: ufs: wb: Change wb_enabled condition testdrivers/ufs/core/ufshcd.c+2 -40 replies
2/6scsi: ufs: wb: Change functions name and modify parameter namedrivers/ufs/core/ufshcd.c+17 -130 replies
3/6scsi: ufs: wb: Add explicit flush sysfs attributeDocumentation/ABI/testing/sysfs-driver-ufs drivers/ufs/core/ufs-sysfs.c drivers/ufs/core/ufshcd.c +1 more+61 -40 replies
4/6scsi: ufs: wb: Introduce ufshcd_is_wb_buf_flush_allowed() to improve readabilitydrivers/ufs/core/ufs-sysfs.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c+10 -40 replies
5/6scsi: ufs: wb: Modify messagesdrivers/ufs/core/ufs-sysfs.c drivers/ufs/core/ufshcd.c+12 -130 replies
6/6scsi: ufs: wb: Move the comment to the right positiondrivers/ufs/core/ufshcd.c+2 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanBean HuoBart Van AsscheStanley Chu
1/6R-b R-b R-b R-b
2/6R-b R-b
3/6R-b
4/6R-b A-b R-b R-b
5/6R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup

This patch series is to clean up UFS's Write Booster code and adds sysfs attribute which can control the specific feature of it.

V2:
- modify commit message
- move & modify err messages
- remove unnesscessary debug messages
V3:
- split patch (functional, non-functional)
V4:
- split patch (The number of patches from 2 to 7)
- modify dev messages
- modify commit message
V5:
- drop (scsi: ufs: wb: Move ufshcd_is_wb_allowed() to callee)
- fix condition check
- add document for sysfs attribute
- move ufshcd_is_wb_buf_flush_allowed() to ufs-priv.h
V6:
- Change the function name from ufshcd_wb_config() to ufshcd_configure_wb()
- modify document description for wb_buf_flush_en attribute
- fix some dev_err messages
V7:
- renaming sysfs attribute name
(wb_buf_flush_en -> enable_wb_buf_flush)
- update document description
- change debug message level (info -> dbg) (5.19/scsi-fixes, https://git.kernel.org/mkp/scsi/c/2ae57c995003)

Jinyoung Choi (6):
scsi: ufs: wb: Change wb_enabled condition test
scsi: ufs: wb: Change functions name and modify parameter name
scsi: ufs: wb: Add explicit flush sysfs attribute
scsi: ufs: wb: Introduce ufshcd_is_wb_buf_flush_allowed() to improve
readability
scsi: ufs: wb: Modify messages
scsi: ufs: wb: Move the comment to the right position

 Documentation/ABI/testing/sysfs-driver-ufs |  9 +++
 drivers/ufs/core/ufs-sysfs.c               | 47 ++++++++++++++-
 drivers/ufs/core/ufshcd-priv.h             |  6 ++
 drivers/ufs/core/ufshcd.c                  | 70 ++++++++++++----------
 include/ufs/ufshcd.h                       |  1 +
 5 files changed, 99 insertions(+), 34 deletions(-)
Signature · 1 line
2.25.1