iwlwifi: mvm: Thermal management fixes
Get series with b4
b4 am 1892445.tdWV9SEqCh@kreacherVersions newest first
- v1 Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | iwlwifi: mvm: Drop unused fw_trips_index[] from iwl_mvm_thermal_devicedrivers/ drivers/ | +1 | 0 replies | |
| 2/3 | iwlwifi: mvm: Populate trip table before registering thermal zonedrivers/ | +9 | 0 replies | |
| 3/3 | iwlwifi: mvm: Use for_each_thermal_trip() for walking trip pointsdrivers/ | +25 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Miri Korenblit |
|---|---|
| Series | A-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/3] iwlwifi: mvm: Thermal management fixes
Hi Everyone,
There are a few thermal management shortcomings in the iwlwifi driver that are addressed by this series.
First off, the fw_trips_index[] array field in struct iwl_mvm_thermal_device is only populated and never read, and the code populating it has problems, so patch [1/3] removes it.
Second, iwl_mvm_thermal_zone_register() populates the trip table after passing it to thermal_zone_device_register_with_trips() which is too late, because it can get used before it is populated. It also may as well use THERMAL_TEMP_INVALID as the "invalid temperature" value. Both these issues are addressed by patch [2/3].
Finally, iwl_mvm_send_temp_report_ths_cmd() accesses the trip tables used during thermal zone registration directly in order to obtain the current trip point temperature values, which is not guaranteed to work in the future, because the core will store the trips information in its own copy of the trip table - see this patch series:
https://lore.kernel.org/linux-pm/2728491.mvXUDI8C0e@kreacher/
If possible, I'd like to route the $subject series through the thermal tree, it is requisite for the above one.
Thanks!