add-patch: render hunks through the pager
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/24 patches 0 repliesNew
- v3 posting 2/24 patches 32 repliesSuperseded
- v2 posting 2/24 patches 3 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 posting 1/2 | 6 patches | 16 replies | Superseded | |
| v3 posting 1/2 | 6 patches | 37 replies | Superseded | |
| v2 posting 1/2 | 5 patches | 4 replies | Superseded | |
| v1 | 5 patches | 30 replies | Superseded |
Patches in v4 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | add-patch: test for 'p' commandt/ | +16 | 0 replies | |
| 2/4 | pager: do not close fd 2 unnecessarilypager.c | +6 | 0 replies | |
| 3/4 | pager: introduce wait_for_pagerpager.c pager.h | +38 | 0 replies | |
| 4/4 | add-patch: render hunks through the pageradd-patch.c t/ | +43 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/4] add-patch: render hunks through the pager
Make the test name more descriptive and avoid unnecessary redirection.
Thanks.
Rubén Justo (4):
add-patch: test for 'p' command
pager: do not close fd 2 unnecessarily
pager: introduce wait_for_pager
add-patch: render hunks through the pager
add-patch.c | 18 ++++++++++++--- pager.c | 45 +++++++++++++++++++++++++++++++++----- pager.h | 1 + t/t3701-add-interactive.sh | 44 +++++++++++++++++++++++++++++++++++++ 4 files changed, 100 insertions(+), 8 deletions(-)
Interdiff against v3:
t/t3701-add-interactive.sh +2 -2
@@ -612,11 +612,11 @@ test_expect_success TTY 'print again the hunk (PAGER)' ' test_cmp expect actual.trimmed ' -test_expect_success TTY 'P does not break if pager ends unexpectedly' ' +test_expect_success TTY 'P handles SIGPIPE when writing to pager' ' test_when_finished "rm -f huge_file; git reset" && printf "\n%2500000s" Y >huge_file && git add -N huge_file && - test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p >actual + test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p ' test_expect_success 'split hunk "add -p (edit)"' '
Signature · 1 line
2.46.0.rc0.4.g229d67bbd7