Skip to content

KVM: x86/mmu: Bug fixes and cleanups in get_mmio_spte()

Richard Herbert kvm lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] KVM: x86/mmu: Bug fixes and cleanups in get_mmio_spte()

Hi, Sean and all.

Thanks so much for these. Very glad to report that the problem has been solved. I applied all four patches, recompiled kernel 5.10.1 and successfully launched a Qemu VM. Let's hope these will get merged into 5.10.2.

Thanks again for the hard work and quick fix.

Richard Herbert

Quoted 15 lines · EST Sean Christopherson

Two fixes for bugs that were introduced along with the TDP MMU (though I strongly suspect only the one reported by Richard, fixed in patch 2/4, is hittable in practice). Two additional cleanup on top to try and make the code a bit more readable and shave a few cycles.

Sean Christopherson (4):
KVM: x86/mmu: Use -1 to flag an undefined spte in get_mmio_spte()
KVM: x86/mmu: Get root level from walkers when retrieving MMIO SPTE
KVM: x86/mmu: Use raw level to index into MMIO walks' sptes array
KVM: x86/mmu: Optimize not-present/MMIO SPTE check in get_mmio_spte()

 arch/x86/kvm/mmu/mmu.c     | 53 +++++++++++++++++++++-----------------
 arch/x86/kvm/mmu/tdp_mmu.c |  9 ++++---
 arch/x86/kvm/mmu/tdp_mmu.h |  4 ++-
 3 files changed, 39 insertions(+), 27 deletions(-)