Skip to content

RFC Backing Store for sysfs (Overhauled)

Maneesh Soni lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 of 5 patches 10 repliesIn review

1 of 5 patches is in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5sysfs-backing-store.patchfs/sysfs/mount.c fs/sysfs/sysfs.h include/linux/kobject.h +1 more+142 -235 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] Backing Store for sysfs (Overhauled)

Hi All,

The following patch set has the overhauled prototype for sysfs backing store for comments. I have tried to keep all the comments and suggestions from the last time in mind.

The main complaint was of over bloating kobject structure which becomes more painful when kobject is not part of sysfs. So now I have changed the data structures entirely. There is _no_ increase in the size of kobject structure. The kobject hierarchy is represented in the form of a new structure called sysfs_dirent (size 48 - bytes). sysfs_dirent will be there only for kobject elements (kobject, attribute, attribute group, symlink) which are represented in sysfs. kobject structre has just one change. Now kobject has a field pointing to its sysfs_dirent instead of dentry.

struct sysfs_dirent {
        struct list_head        s_sibling;
        struct list_head        s_children;
        void                    * s_element;
        struct dentry           * s_dentry;
        int                     s_type;
        struct rw_semaphore     s_rwsem;
};

The concept is still the same that in this prototype also we create dentry and inode on the fly when they are first looked up. This is done for both leaf or non-leaf dentries. The generic nature of sysfs_dirent makes it easy to do for both leaf or non-leaf dentries.

Please review the patches following this posting. For testing apply all the patches as they are splitted just for review.

Thanks
Maneesh

Signature · 6 lines
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: [email protected]
Phone: 91-80-5044999 Fax: 91-80-5268553
T/L : 9243696