orinoco merge preliminaries
Get series with b4
b4 am 20040728065128.GC16908@zaxVersions newest first
- v1 Latest15 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | orinoco merge preliminaries - squash backwards compatibilitydrivers/ drivers/ drivers/ +3 more | +2 | 0 replies | |
| 2/15 | orinoco merge preliminaries - rearrange codedrivers/ drivers/ drivers/ +1 more | +1388 | 0 replies | |
| 3/15 | orinoco merge preliminaries - use netdev_priv()drivers/ drivers/ drivers/ +3 more | +15 | 0 replies | |
| 4/15 | orinoco merge preliminaries - use ALIGN()drivers/ | +2 | 0 replies | |
| 5/15 | orinoco merge preliminaries - use ARRAY_SIZE()drivers/ | +2 | 0 replies | |
| 6/15 | orinoco merge preliminaries - spam stoppersdrivers/ drivers/ drivers/ +1 more | +22 | 1 reply | |
| 7/15 | orinoco merge preliminaries - comment/whitespace/spelling updatesdrivers/ drivers/ drivers/ +7 more | +277 | 0 replies | |
| 8/15 | orinoco merge preliminaries - use BUG_ON()drivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 9/15 | orinoco merge preliminaries - make things staticdrivers/ drivers/ drivers/ +1 more | +10 | 0 replies | |
| 10/15 | orinoco merge preliminaries - miscelaneousdrivers/ drivers/ | +2 | 0 replies | |
| 11/15 | orinoco merge preliminaries - use name/version macrosdrivers/ drivers/ drivers/ +4 more | +64 | 0 replies | |
| 12/15 | orinoco merge preliminaries - remove unneeded #includesdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 13/15 | orinoco merge preliminaries - don't typedef structsdrivers/ drivers/ drivers/ | +7 | 0 replies | |
| 14/15 | orinoco merge preliminaries - more HW datadrivers/ drivers/ | +80 | 0 replies | |
| 15/15 | orinoco merge preliminaries - update authorship informationMAINTAINERS drivers/ drivers/ +6 more | +48 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [0/15] orinoco merge preliminaries
Quoted 10 lines · Jeff Garzik
Quoted 10 lines
I've started to have a look at the patches. Unfortunately, they're still not really as logically separated as they should be. Which I guess means I wasn't sufficiently disciplined putting them into CVS in the first place.
I've started working on my own series of logical patches, starting with, as you say the "content free" ones first. Initial set with series file at
http://www.ozlabs.org/people/dgibson/orinoco-patches
Quoted 6 lines
Quoted 1 line
Nothing there so far that should cause any functional change.
Feel free to start emailing them, so I can queue them up.
One email per patch, please.
Ok, patchbombing commences.
Following are 15 patches which make a start on merging the current CVS orinoco driver into the mainline tree. This batch of patches is only preliminaries - patches which cause no behavioural change, but which should be easy to review and which will reduce meaningless noise in the later functional patches.
They all represent essentially trivial changes, and with the exception of the rearrange patch (which is large because it moves big chunks of code around) they should be obvious. This batch of patches is supposed to represent all the trivial, non-behaviour-changing differences between orinoco CVS and mainline, though the merge is so large, inevitably I will have missed a few.
Summary of the patches:
1/15 orinoco-squash-backwards-compat: Removes old unnecessary backwards compatibility code 2/15 orinoco-rearrange: Rearrange code so function order matches new versions 3/15 orinoco-netdev-priv: Use netdev_priv() instead of direct dev->priv access 4/15 orinoco-ALIGN: Use standard ALIGN macro instead of local versions 5/15 orinoco-ARRAY-SIZE: Use ARRAY_SIZE macro instead of local version 6/15 orinoco-spam-stoppers: Anti-spam obfuscate email addresses in source 7/15 orinoco-comments-whitespace-spelling Whitespace/spelling/capitalisation updates 8/15 orinoco-BUG-ON: Use BUG_ON() instead of explicit if () BUG() logic 9/15 orinoco-add-statics: Make some functions static that always should have been 10/15 orinoco-trivial-cleanup: Tiny changes than don't belong with anything else 11/15 orinoco-driver-name-version: Reduce duplication of the driver names/version 12/15 orinoco-uneeded-includes: Remove unnecessary #includes 13/15 orinoco-no-struct-typedef: Don't use typedefs on simple structues 14/15 orinoco-more-hw-data: Extra hw related #defines and structures 15/15 orinoco-update-authorship: Update MAINTAINERS, copyright banners, etc.
Signature · 4 lines
David Gibson | For every complex problem there is a david AT gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson