Skip to content

orinoco merge preliminaries

David Gibson lkml 1 version In review

Get series with b4
b4 am 20040728065128.GC16908@zax

Versions newest first

  1. v1 Latest15 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15orinoco merge preliminaries - squash backwards compatibilitydrivers/net/wireless/hermes.c drivers/net/wireless/orinoco.c drivers/net/wireless/orinoco.h +3 more+2 -640 replies
2/15orinoco merge preliminaries - rearrange codedrivers/net/wireless/hermes.h drivers/net/wireless/hermes_rid.h drivers/net/wireless/orinoco.c +1 more+1388 -14040 replies
3/15orinoco merge preliminaries - use netdev_priv()drivers/net/wireless/airport.c drivers/net/wireless/orinoco.c drivers/net/wireless/orinoco_cs.c +3 more+15 -150 replies
4/15orinoco merge preliminaries - use ALIGN()drivers/net/wireless/orinoco.c+2 -40 replies
5/15orinoco merge preliminaries - use ARRAY_SIZE()drivers/net/wireless/orinoco.c+2 -20 replies
6/15orinoco merge preliminaries - spam stoppersdrivers/net/wireless/orinoco.c drivers/net/wireless/orinoco_pci.c drivers/net/wireless/orinoco_plx.c +1 more+22 -211 reply
7/15orinoco merge preliminaries - comment/whitespace/spelling updatesdrivers/net/wireless/hermes.c drivers/net/wireless/hermes.h drivers/net/wireless/hermes_rid.h +7 more+277 -2430 replies
8/15orinoco merge preliminaries - use BUG_ON()drivers/net/wireless/orinoco.c drivers/net/wireless/orinoco_cs.c drivers/net/wireless/orinoco_plx.c +1 more+9 -150 replies
9/15orinoco merge preliminaries - make things staticdrivers/net/wireless/orinoco.c drivers/net/wireless/orinoco_pci.c drivers/net/wireless/orinoco_plx.c +1 more+10 -100 replies
10/15orinoco merge preliminaries - miscelaneousdrivers/net/wireless/orinoco.c drivers/net/wireless/orinoco_tmd.c+2 -20 replies
11/15orinoco merge preliminaries - use name/version macrosdrivers/net/wireless/airport.c drivers/net/wireless/orinoco.c drivers/net/wireless/orinoco.h +4 more+64 -430 replies
12/15orinoco merge preliminaries - remove unneeded #includesdrivers/net/wireless/orinoco_pci.c drivers/net/wireless/orinoco_plx.c drivers/net/wireless/orinoco_tmd.c+0 -30 replies
13/15orinoco merge preliminaries - don't typedef structsdrivers/net/wireless/hermes.c drivers/net/wireless/hermes.h drivers/net/wireless/orinoco.c+7 -70 replies
14/15orinoco merge preliminaries - more HW datadrivers/net/wireless/hermes.h drivers/net/wireless/hermes_rid.h+80 -130 replies
15/15orinoco merge preliminaries - update authorship informationMAINTAINERS drivers/net/wireless/airport.c drivers/net/wireless/hermes.c +6 more+48 -241 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [0/15] orinoco merge preliminaries
Quoted 10 lines · Jeff Garzik
Quoted 10 lines

I've started to have a look at the patches. Unfortunately, they're still not really as logically separated as they should be. Which I guess means I wasn't sufficiently disciplined putting them into CVS in the first place.

I've started working on my own series of logical patches, starting with, as you say the "content free" ones first. Initial set with series file at
http://www.ozlabs.org/people/dgibson/orinoco-patches

Quoted 6 lines
Quoted 1 line

Nothing there so far that should cause any functional change.

Feel free to start emailing them, so I can queue them up.

One email per patch, please.

Ok, patchbombing commences.

Following are 15 patches which make a start on merging the current CVS orinoco driver into the mainline tree. This batch of patches is only preliminaries - patches which cause no behavioural change, but which should be easy to review and which will reduce meaningless noise in the later functional patches.

They all represent essentially trivial changes, and with the exception of the rearrange patch (which is large because it moves big chunks of code around) they should be obvious. This batch of patches is supposed to represent all the trivial, non-behaviour-changing differences between orinoco CVS and mainline, though the merge is so large, inevitably I will have missed a few.

Summary of the patches:

	1/15 orinoco-squash-backwards-compat:
		Removes old unnecessary backwards compatibility code
	2/15 orinoco-rearrange:
		Rearrange code so function order matches new versions
	3/15 orinoco-netdev-priv:
		Use netdev_priv() instead of direct dev->priv access
	4/15 orinoco-ALIGN:
		Use standard ALIGN macro instead of local versions
	5/15 orinoco-ARRAY-SIZE:
		Use ARRAY_SIZE macro instead of local version
	6/15 orinoco-spam-stoppers:
		Anti-spam obfuscate email addresses in source
	7/15 orinoco-comments-whitespace-spelling
		Whitespace/spelling/capitalisation updates
	8/15 orinoco-BUG-ON:
		Use BUG_ON() instead of explicit if () BUG() logic
	9/15 orinoco-add-statics:
		Make some functions static that always should have been
	10/15 orinoco-trivial-cleanup:
		Tiny changes than don't belong with anything else
	11/15 orinoco-driver-name-version:
		Reduce duplication of the driver names/version
	12/15 orinoco-uneeded-includes:
		Remove unnecessary #includes
	13/15 orinoco-no-struct-typedef:
		Don't use typedefs on simple structues
	14/15 orinoco-more-hw-data:
		Extra hw related #defines and structures
	15/15 orinoco-update-authorship:
		Update MAINTAINERS, copyright banners, etc.
Signature · 4 lines
David Gibson			| For every complex problem there is a
david AT gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.
http://www.ozlabs.org/people/dgibson