Skip to content

PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator

Thomas Graf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PKT_SCHED: Replace tc_stats with new gnet_stats in struct Qdiscinclude/net/pkt_sched.h net/sched/sch_cbq.c net/sched/sch_dsmark.c +12 more+111 -1080 replies
2/5PKT_SCHED: Use gnet_stats API to copy statistics into netlink messageinclude/linux/rtnetlink.h net/sched/sch_api.c+17 -20 replies
3/5PKT_SCHED: Introduce gen_replace_estimatorinclude/net/gen_stats.h net/core/gen_estimator.c+14 -00 replies
4/5PKT_SCHED: Use generic rate estimatornet/sched/sch_api.c net/sched/sch_generic.c+6 -80 replies
5/5PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselvesnet/sched/sch_hfsc.c net/sched/sch_htb.c+0 -74 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator

Dave,

This patchset converts Qdiscs to use the generic network statistics/estimator. A new TLV type TCA_STATS2 is introduced carrying the new statistics while the old TLV type TCA_STATS is still provided for backward compatibility.

Patch 1: Replace tc_stats with new gnet_stats in struct Qdisc Patch 2: Use gnet_stats API to copy statistics into netlink message Patch 3: Introduce gen_replace_estimator
Patch 4: Use generic rate estimator
Patch 5: Qdisc are not supposed to dump TCA_STATS themselves

I tested these patches for a few days and didn't encounter any problems. iproute2 is able to read out statistics via backward compatibility. A slightly patched iproute2 can read the new statistics.