Skip to content

PKT_SCHED: overall net/pkt_cls.h and net/pkt_sched.h cleanup

Thomas Graf netdev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/11PKT_SCHED: linux/pkt_cls.h depends on linux/pkt_sched.hinclude/linux/pkt_cls.h+2 -00 replies
2/11PKT_SCHED: Add net/sch_generic.h with generic sched definitionsinclude/net/sch_generic.h+175 -00 replies
3/11PKT_SCHED: Remove obsolete definitions in pkt_cls.hinclude/net/pkt_cls.h+1 -590 replies
4/11PKT_SCHED: Add net/act_api.h with public action/policer bitsinclude/net/act_api.h+122 -00 replies
5/11PKT_SCHED: Remove obsolete definitions in pkt_sched.hinclude/net/pkt_sched.h+1 -2180 replies
6/11PKT_SCHED: Transform prototypes to be externinclude/net/pkt_sched.h+18 -150 replies
7/11PKT_SCHED: Move tc_classify from pkt_cls.h to sch_api.cinclude/net/pkt_cls.h include/net/pkt_sched.h net/sched/sch_api.c+50 -450 replies
8/11PKT_SCHED: psched_*_per_* can be staticnet/sched/sch_api.c+2 -20 replies
9/11PKT_SCHED: Cleanup cls_set_classinclude/net/pkt_cls.h include/net/pkt_sched.h net/sched/cls_api.c+25 -264 replies
10/11PKT_SCHED: Inline psched_tod_diffinclude/net/pkt_sched.h net/sched/sch_api.c+12 -160 replies
11/11: PKT_SCHED: Use new header architectureinclude/net/tc_act/tc_gact.h include/net/tc_act/tc_mirred.h net/sched/act_api.c +8 more+18 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/11] PKT_SCHED: overall net/pkt_cls.h and net/pkt_sched.h cleanup

Dave,

This patchset attempts to clean up the mess in net/pkt_sched.h and net/pkt_cls.h grown over the last years.

It introduces net/sch_generic.h containing all generic sch/cls bits and act_api.h containing pubic action/policer bits.

The current architecture which is basically to have net/pkt_sched.h include net/pkt_cls.h and everyone just including net/pkt_sched.h makes it impossible to add any generic classifer bits into pkt_cls.h and acted just like if we had put it into one big file.

Tested for nearly a week with various combinations of action/policer configurations.

See patch descriptions for more details.

Dave, Jamal: The only difference to the previous patchset is that it doesn't touch qdisc_tree_lock and qdisc_lookup anymore but let cls_api.c include net/pkt_sched.h which makes more sense. I splitted up the patches a bit more to improve readability for the review.