Skip to content

PKT_SCHED: Use gnet_stats for actions and policer

Thomas Graf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tcf_action: copy generic stats via TCA_ACT_STATSinclude/linux/rtnetlink.h include/net/act_api.h include/net/pkt_act.h +1 more+37 -80 replies
2/8gact: use gnet_stats for action statsnet/sched/gact.c+4 -160 replies
3/8ipt: use gnet_stats for action statsnet/sched/ipt.c+5 -180 replies
4/8mirred: use gnet_stats for action statsnet/sched/mirred.c+5 -180 replies
5/8pedit: use gnet_stats for action statsnet/sched/pedit.c+3 -150 replies
6/8police: use gnet_stats for action policer statsnet/sched/police.c+6 -170 replies
7/8police: use gnet_stats for old policer statsinclude/net/act_api.h net/sched/police.c+36 -80 replies
8/8cls_*: use tcf_police_dump_stats to dump via new gnet_stats APInet/sched/cls_fw.c net/sched/cls_route.c net/sched/cls_rsvp.h +1 more+8 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/8] PKT_SCHED: Use gnet_stats for actions and policer

Dave,

This is the last patchset in my attempt to clean up traffic control statistics. It converts the action and policer code to the gnet_stats API.

I decided to not provide backward compatibility for action statistics and introduce a new TLV type TCA_ACT_STATS for them in order to get some consistency and be prepared if we ever introduce statistics to classifiers. This was approved by Jamal.

Shall I mark the old estimator and statistic API as __deprecated or remove it right away?

Cheers