Skip to content

New set of input patches

Dmitry Torokhov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16i8042 panicblink cleanupDocumentation/kernel-parameters.txt drivers/input/serio/i8042.c+25 -130 replies
2/16Add serio start and stop methodsdrivers/input/serio/serio.c include/linux/serio.h+9 -10 replies
3/16i8042: Make use of new serio start and stop methodsdrivers/input/serio/i8042.c drivers/input/serio/i8042.h+165 -1600 replies
4/16Suppress duplicate events in serio coredrivers/input/serio/serio.c+48 -90 replies
5/16evdev: return -EINVAL if read buffer is too smalldrivers/input/evdev.c+3 -00 replies
6/16Propery set up name for PS/2 Logitech micedrivers/input/mouse/logips2pp.c+13 -20 replies
7/16Limit Synaptics rate on Toshiba Satellitesdrivers/input/mouse/synaptics.c+26 -00 replies
8/16Allow setkeycodes work againdrivers/input/keyboard/atkbd.c+4 -40 replies
9/16i8042: fix sysfs permissiions for 'debug' parameterdrivers/input/serio/i8042.c+1 -10 replies
10/16Fix building twidjoy moduledrivers/input/joystick/Kconfig drivers/input/joystick/twidjoy.c+4 -20 replies
11/16Use msecs_to_jiffies in input coredrivers/input/input.c+4 -110 replies
12/16Use msecs_to_jiffies in atkbddrivers/input/keyboard/atkbd.c+1 -10 replies
13/16Introduce serio_get/set_drvdata helpersdrivers/input/joystick/iforce/iforce-serio.c drivers/input/joystick/magellan.c drivers/input/joystick/spaceball.c +17 more+149 -800 replies
14/16Introduce serio_id to match ports and driversdrivers/input/joystick/iforce/iforce-serio.c drivers/input/joystick/magellan.c drivers/input/joystick/spaceball.c +31 more+334 -1460 replies
15/16serio bus implementation cleanupdrivers/input/mouse/psmouse-base.c drivers/input/mouse/synaptics.c drivers/input/serio/serio.c +1 more+219 -1820 replies
16/16serio connect methods should return error codesdrivers/input/joystick/iforce/iforce-serio.c drivers/input/joystick/magellan.c drivers/input/joystick/spaceorb.c +15 more+142 -730 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/16] New set of input patches

Hi Vojtech,

Please take a look at the following input patches. Patches 1-9 are already in my tree (and were there for quite some time so they should have gotten at least some testing as Andrew automatically pulls from me) and I'd like see them pushed to Linus together with your last batch. At least patches 6, 8 and 9 fix bugs introduced by latest changes. Patch 7 should help owners of Toshibas with Synaptics touchpads.

01-i8042-panicblink-cleanup.patch
Move panicblink parameter definition together with the rest of i8042 module parameters, add description and entry in kernel-parameters.txt

02-serio-start-stop.patch
Add serio start() and stop() methods to serio structure that are called when serio port is about to be fully registered and when serio port is about to be unregistered. These methods are useful for drivers that share interrupt among several serio ports. In this case interrupt can not be enabled/disabled in open/close methods and it is very hard to determine if interrupt shoudl be ignored or passed on.

03-i8042-use-start-stop.patch
Make use of new serio start/stop methods to safely activate and deactivate ports. Also unify as much as possible port handling between KBD, AUX and MUX ports. Rename i8042_values into i8042_port.

04-serio-suppress-dup-events.patch
Do not submit serio event into event queue if there is already one of the same type for the same port in front of it. Also look for duplicat events once event is processed. This should help with disconnected ports generating alot of data and consuming memory for events when kseriod gets behind and prevents constant rescans. This also allows to remove special check for 0xaa in reconnect path of interrupt handler known to cause problems with Toshibas keyboards.

05-evdev-buffer-size.patch
Return -EINVAL from evdev_read when passed buffer is too small. Based on patch by James Lamanna.

06-ps2pp-mouse-name.patch
Set mouse name to "Mouse" instead of leaving it NULL when using PS2++ protocol and don't have any other information (Wheel, Touchpad) about the mouse.

07-synaptics-toshiba-rate.patch
Toshiba Satellite KBCs have trouble handling data stream coming from Synaptics at full rate (80 pps, 480 byte/sec) which causes keyboards to pause or even get stuck. Use DMI to detect Satellites and limit rate to 40 pps which cures keyboard.

08-atkbd-keycode-size.patch
Fix keycode table size initialization that got broken by my changes that exported 'set' and other settings via sysfs. setkeycodes should work again now.

09-i8042-sysfs-permissions.patch
Fix braindamage in sysfs permissions for 'debug' option.

10-twidjoy-build.patch
Make Kconfig and Makefile agree on the option name so twidjoy can be built.

11-input-msecs-to-jiffies.patch

	Use msecs_to_jiffies instead of homegrown ms_to_jiffies
	so everything works when HZ != 1000

12-atkbd-msecs-to-jiffies.patch
Use msecs_to_jiffies instead of manually calculating delay for Toshiba bouncing keys workaround so it works when HZ != 1000.

13-serio-drvdata.patch
Remove serio->private in favor of using driver-specific data in device structure, add serio_get_drvdata/serio_put_drvdata to access it so serio bus code looks more like other buses.

14-serio-id-match.patch
Replace serio's type field with serio_id structure and add ids table to serio drivers. This will allow splitting initial matching and probing routines for better sysfs integration.

15-serio-bus-cleanup.patch
Make serio implementation more in line with standard driver model implementations by removing explicit device and driver list manipulations and introducing bus_match function. serio_register_port is always asynchronous to allow freely registering child ports. When deregistering serio core still takes care of destroying children ports first.

16-serio-connect-errcode.patch
Make serios' connect methods return error code instead of void so exact cause of failur can be comminicated upstream.

Let me know which ones will you take and I will push them to my tree as well.

Thanks!

Signature · 1 line
Dmitry