Skip to content

PKT_SCHED: tcf_exts API & make classifier changes consistent upon failure

Thomas Graf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9PKT_SCHED: rtattr_parse shortcut for nested TLVsinclude/linux/rtnetlink.h+3 -00 replies
2/9PKT_SCHED: tc filter extension APIinclude/net/pkt_cls.h net/sched/cls_api.c+248 -013 replies
2/9PKT_SCHED: tc filter extension APIinclude/net/pkt_cls.h net/sched/cls_api.c+248 -00 replies
2/9PKT_SCHED: tc filter extension APIinclude/net/pkt_cls.h net/sched/cls_api.c+236 -00 replies
2/9PKT_SCHED: tc filter extension APIinclude/net/pkt_cls.h net/sched/cls_api.c+240 -00 replies
3/9PKT_SCHED: u32: make use of tcf_exts APInet/sched/cls_u32.c+40 -842 replies
4/9PKT_SCHED: fw: make use of tcf_exts APInet/sched/cls_fw.c+39 -980 replies
5/9PKT_SCHED: route: allow changing parameters for existing filters and use tcf_exts APIinclude/linux/pkt_cls.h net/sched/cls_route.c+190 -1570 replies
6/9PKT_SCHED: tcindex: allow changing parameters for existing filters and use tcf_exts APIinclude/linux/pkt_cls.h net/sched/cls_tcindex.c+211 -1690 replies
7/9PKT_SCHED: rsvp: use tcf_exts APIinclude/linux/pkt_cls.h net/sched/cls_rsvp.h+50 -530 replies
8/9PKT_SCHED: Remove old action/police helpersinclude/net/pkt_cls.h+0 -1220 replies
9/9PKT_SCHED: Actions are now available for all classifiersnet/sched/Kconfig+0 -10 replies
9/9PKT_SCHED: Actions are now available for all classifiers & Fix police Kconfig dependenciesnet/sched/Kconfig+8 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] PKT_SCHED: tcf_exts API & make classifier changes consistent upon failure

Dave,

The following patchset adds tcf_exts API to remove the ifdef clutter, helps make changes consistent upon failures, makes adding action bits to yet unsupported classifiers as easy as adding a few lines and generally saves a lot of code per classifier. The patches to make use of the API add action support to all classifiers and makes changes consistent except for indev failures (to be removed soon) and rsvp which needs a closer look since i haven't had time to perfectly understand it yet.

I gave it extensive testing for 2 weeks, patches 5-6 are non-trivial though and it's quite hard to test everything. I will post a request to the lartc mailinglist once these changes are in a bk release so everyone can try it out and I have time fix any remaining issues before the next rc release. I could provide the patchset but its quite some work for the testers and I guess there will be more people trying it out if they can use an official release.

Cheers, Thomas