Skip to content

I8K driver facelift

Dmitry Torokhov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5I8K - pass though Lindentdrivers/char/i8k.c+477 -4770 replies
2/5I8K - use standard DMI functionsDocumentation/kernel-parameters.txt arch/i386/kernel/dmi_scan.c drivers/char/i8k.c +1 more+60 -2490 replies
3/5I8K - switch to seq_filedrivers/char/i8k.c+22 -420 replies
4/5I8K - switch to module_{init|exit}drivers/char/i8k.c drivers/char/misc.c+47 -1060 replies
5/5I8K - convert to platform device (sysfs)drivers/char/i8k.c+117 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] I8K driver facelift

Hi,

here are some changes that freshen I8K driver (Dell Inspiron/Latitude platform driver). The patches have been tested on Inspiron 8100.

i8k-lindent.patch
- pass the driver through Lindent to comply with CondingStyle requirements (4 spaces vs. TAB indentation)

i8k-use-dmi.patch
- use standard DMI handling functions instead of homemade ones. The driver now requires DMI data to match list of supported models - this way driver can be safely enabled without fear of it poking into SMM code on wrong box. DMI checks can be ignored with i8k.ignore_dmi option.

i8k-seqfile.patch
- switch proc handlig code to seq_file instead of having custom read function splitting output to fit into user's buffer.

i8k-cleanup.patch
- use module_{init|exit} instead of old-style module intialization code, some formatting changes.

i8k-sysfs.patch
- make i8k a platform device and export temperatiure and both fan states as sysfs attributes. Wringing into fan1_state and fan2_state attributes allows switching fans on and off without need for special utility.

Please consider for inclusion.

Thanks!

Signature · 1 line
Dmitry