Misc driver core changes (constness)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | kobject_hotplug() should use kobject_name()lib/ | +2 | 0 replies | |
| 2/5 | sysfs_{create|remove}_link should take const char *fs/ include/ | +9 | 0 replies | |
| 3/5 | Make kobject's name be const char *include/ lib/ lib/ | +6 | 0 replies | |
| 4/5 | kset_hotplug_ops->name shoudl return const char *drivers/ drivers/ include/ | +3 | 0 replies | |
| 5/5 | make driver's name be const char *drivers/ include/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Misc driver core changes (constness)
Hi,
It all started when code like this:
static const char driver_name = "blah";
static struct device_driver {
.name = driver_name,
};
would give me compiler warning about removing constness because driver core has "name" fields drclared simply as "char *". I think it is a good idea to have them as "const char *" since whoever accesses them should not try to change them.
01-hotplug-use-kobject-name.patch
- kobject_hotplug should use kobject_name() instead of accessing kobj->name directly since for objects with long names it can contain garbage.
02-sysfs-link-constness.patch
- make sysfs_{create|remove}_link to take const char * name.
03-kobject-const-name.patch
- make kobject's name const char * since users should not attempt to change it (except by calling kobject_rename).
04-kset-name-const.patch
- change name() method in kset_hiotplug_ops return const char * since users shoudl not try to modify returned data.
05-driver-const-name.patch
- change driver's, bus's, class's and platform device's names to be const char * so one can use const char *drv_name = "asdfg"; when initializing structures.
Also kill couple of whitespaces.
Please consider for inclusion.
Signature · 1 line
Dmitry