Skip to content

I8K and Toshiba legacy driver cleanup

Dmitry Torokhov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Toshiba driver cleanupdrivers/char/misc.c drivers/char/toshiba.c+24 -403 replies
2/6I8K: pass through lindentdrivers/char/i8k.c+477 -4770 replies
3/6I8K: use standard DMI interfaceDocumentation/kernel-parameters.txt arch/i386/kernel/dmi_scan.c drivers/char/i8k.c +1 more+58 -2491 reply
4/6I8K: convert to seqfiledrivers/char/i8k.c+22 -420 replies
5/6I8K: initialization code cleanup; formattingdrivers/char/i8k.c drivers/char/misc.c+47 -1060 replies
6/6I8K: add new BIOS signaturesdrivers/char/i8k.c+24 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] I8K and Toshiba legacy driver cleanup

Hi Andrew,

I have several patches cleaning up Toshiba and I8K drivers a bit and I was wondering if you could add them to -mm. I8K patches have been sent to LKML earlier and were tested (although I have dropped sysfs export patch, there were some objections from Greg).

01-toshiba-cleanup
Toshiba legacy driver cleanup:
- use module_init/module_exit for initialization instead of using

    #ifdef MODULE and calling tosh_init manually from drivers/char/misc.c

- do not explicitly initialize static variables
- some whitespace and formatting cleanups

02-i8k-lindent.patch
- pass through Lindent to change 4 spaces identation to TABs

03-i8k-use-dmi.patch
- Change to use stock dmi infrastructure instead of homegrown parsing code. The driver now requires box's DMI data to match list of supported models so driver can be safely compiled-in by default without fear of it poking into random SMM BIOS code. DMI checks can be ignored with i8k.ignore_dmi option.

04-i8k-seqfile.patch
- Change proc code to use seq_file.

05-i8k-cleanup.patch
- use module_{init|exit} instead of old style #ifdef MODULE code, some formatting changes

06-i8k-new-signatures.patch
- add BIOS signatures of a newer Dell laptops, also there can be more than one temperature sensor reported by BIOS.

Thanks!

Signature · 1 line
Dmitry

Read the cover letter in its thread