Skip to content

decrapify FlashPoint

Alexey Dobriyan kernel-janitors 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15FlashPoint: remove unused thingsdrivers/scsi/FlashPoint.c+4 -3470 replies
2/15FlashPoint: remove trivial wrappersdrivers/scsi/FlashPoint.c+19 -350 replies
3/15FlashPoint: remove UCHAR+0 -00 replies
4/15FlashPoint: remove USHORTdrivers/scsi/FlashPoint.c+58 -590 replies
5/15FlashPoint: remove UINTdrivers/scsi/FlashPoint.c+7 -82 replies
6/15FlashPoint: remove ULONG+0 -00 replies
7/15FlashPoint: remove ushort_ptrdrivers/scsi/FlashPoint.c+2 -30 replies
8/15FlashPoint: use standard fixed size types.drivers/scsi/FlashPoint.c+7 -130 replies
9/15FlashPoint: untypedef struct _SCCBdrivers/scsi/FlashPoint.c+71 -720 replies
10/15FlashPoint: untypedef struct SCCBMgr_infodrivers/scsi/FlashPoint.c+7 -80 replies
11/15FlashPoint: untypedef struct SCCBMgr_tar_infodrivers/scsi/FlashPoint.c+26 -270 replies
12/15FlashPoint: untypedef struct NVRAMInfodrivers/scsi/FlashPoint.c+13 -140 replies
13/15FlashPoint: untypedef struct SCCBcarddrivers/scsi/FlashPoint.c+71 -720 replies
14/15./scripts/Lindent drivers/scsi/FlashPoint.c+0 -00 replies
15/15FlashPoint: don't use parenthesis with "return"drivers/scsi/FlashPoint.c+65 -650 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [KJ] [PATCH 0/15] decrapify FlashPoint

Don't pay attention to whatever whitespace left/added on the way. Lindent will take care of it.

1) Mostly remove unused #defines.
2) Remove wrappers.

3-7) Switch to sane types.
8-13) Remove useless typedefs.

Splitted for your reviewing pleasure.

14) Lindent the sucker.
15) return (*); => return *;

Compile tested with CONFIG_SCSI_OMIT_FLASHPOINT=y and =n.

If somebody will find useful the following script used in preparation of the series, I'll be glad.
============================================================================

$ cat prepare
#!/bin/sh

PATCH="$1"
TEMP=${PATCH}_
echo "[PATCH] " >$TEMP
echo "" >>$TEMP
echo "Signed-off-by: Alexey Dobriyan <[email protected]>" >>$TEMP echo "---" >>$TEMP
echo "" >>$TEMP
diffstat -p1 $PATCH >>$TEMP
echo "" >>$TEMP
cat $PATCH >>$TEMP
mv $TEMP $PATCH

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors