Skip to content

fix-up schedule_timeout() usage

Nishanth Aravamudan alsa-devel linux-acpi linux-mips linux-raid linux-scsi linux-serial linux-um linuxppc-dev lkml netdev reiserfs-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 of 32 patches 10 repliesIn review

18 of 32 patches are in this archive. The cover letter announces 32.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32include: update jiffies/{m,u}secs conversion functionsinclude/linux/jiffies.h include/linux/time.h+24 -202 replies
2/32fs: fix-up schedule_timeout() usagefs/cifs/cifsfs.c fs/cifs/connect.c fs/jbd/transaction.c +8 more+23 -385 replies
3/32kernel: fix-up schedule_timeout() usagekernel/compat.c kernel/signal.c kernel/timer.c+10 -200 replies
4/32mm: fix-up schedule_timeout() usagemm/oom_kill.c mm/swapfile.c+2 -40 replies
6/32sound: fix-up schedule_timeout() usagesound/core/seq/seq_instr.c sound/core/seq/seq_lock.c sound/core/seq/seq_memory.c +25 more+51 -1120 replies
9/32ia64: fix-up schedule_timeout() usagearch/ia64/hp/sim/simserial.c+2 -40 replies
11/32mips: fix-up schedule_timeout() usagearch/mips/kernel/irixsig.c arch/mips/kernel/sysirix.c+3 -170 replies
12/32ppc: fix-up schedule_timeout() usagearch/ppc/4xx_io/serial_sicc.c arch/ppc/8260_io/fcc_enet.c+8 -120 replies
14/32um: fix-up schedule_timeout() usagearch/um/drivers/random.c+2 -41 reply
17/32drivers/cdrom: fix-up schedule_timeout() usagedrivers/cdrom/sbpcd.c drivers/cdrom/sonycd535.c+2 -40 replies
19/32drivers/dlm: fix-up schedule_timeout() usagedrivers/dlm/lockspace.c+1 -20 replies
23/32drivers/macintosh: fix-up schedule_timeout() usagedrivers/macintosh/therm_pm72.c+1 -20 replies
24/32drivers/md: fix-up schedule_timeout() usagedrivers/md/raid5.c drivers/md/raid6main.c+2 -40 replies
26/32message: fix-up schedule_timeout() usagedrivers/message/fusion/mptlan.c drivers/message/fusion/mptscsih.c drivers/message/i2o/iop.c+11 -200 replies
28/32drivers/sbus: fix-up schedule_timeout() usagedrivers/sbus/char/bpp.c drivers/sbus/char/vfc_i2c.c+2 -40 replies
29/32drivers/scsi: fix-up schedule_timeout() usagedrivers/scsi/NCR5380.c drivers/scsi/aacraid/rkt.c drivers/scsi/aacraid/rx.c +5 more+29 -602 replies
30/32serial: fix-up schedule_timeout() usagedrivers/serial/crisv10.c+3 -60 replies
31/32telephony: fix-up schedule_timeout() usagedrivers/telephony/ixj.c+18 -360 replies

Reviews trailers per patch

1 of 18 patches has a Reviewed-by or Acked-by.

PatchJeff Dike
1/32
2/32
3/32
4/32
6/32
9/32
11/32
12/32
14/32A-b
17/32
19/32
23/32
24/32
26/32
28/32
29/32
30/32
31/32

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [-mm PATCH 0/32] fix-up schedule_timeout() usage

Hello Andrew,

Sorry for the lack of a combined To:/Cc: list, but it would have been excessive if I included everyone (I won't send all of the patches to LKML, unless there is no other list entry in MAINTAINERS - I think that is only 9 out of the 32 patches :)

Andrew recently added schedule_timeout_interruptible() and schedule_timeout_uninterruptible() to the -mm tree, as schedule_timeout() called without the state set results in an immediate return; thus, it makes little sense to ever call it that way. Almost all the kernel invocations of schedule_timeout(), additionally, follow:

	set_current_state(TASK_{,UN}INTERRUPTIBLE);
	schedule_timeout(some_value_in_jiffies);

Andrew pointed out that creating non-inline wrappers for this common usage should reduce the kernel size. The following 32 patches (split up by directory/subsystem) convert the schedule_timeout() callers in 2.6.13-rc5-mm1, where appropriate.

Here's the list of patches as I split them up:

01/32: include/
02/32: fs/
03/32: kernel/
04/32: mm/
05/32: net/
06/32: sound/
07/32: arch/alpha
08/32: arch/i386
09/32: arch/ia64
10/32: arch/m68k
11/32: arch/mips
12/32: arch/ppc
13/32: arch/ppc64
14/32: arch/um
15/32: drivers/acpi
16/32: drivers/block
17/32: drivers/cdrom
18/32: drivers/char
19/32: drivers/dlm
20/32: drivers/net
21/32: drivers/ieee1394
22/32: drivers/isdn
23/32: drivers/macintosh
24/32: drivers/md
25/32: drivers/media
26/32: drivers/message
27/32: drivers/parport
28/32: drivers/sbus
29/32: drivers/scsi
30/32: drivers/serial
31/32: drivers/telephony
32/32: drivers/usb

Thanks,
Nish