Skip to content

qla4xxx: new driver -- request for review.

Andrew Vasquez linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 8 patches 7 repliesIn review

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/8qla4xxx: initialization routinesdrivers/scsi/qla4xxx/ql4_init.c drivers/scsi/qla4xxx/ql4_iocb.c+2348 -01 reply
3/8qla4xxx: OS integration filesdrivers/scsi/Kconfig drivers/scsi/Makefile drivers/scsi/qla4xxx/Kconfig +3 more+2650 -00 replies
4/8qla4xxx: iSNS routinesdrivers/scsi/qla4xxx/ql4_isns.c drivers/scsi/qla4xxx/ql4_isns.h+2624 -00 replies
5/8qla4xxx: ISR routinesdrivers/scsi/qla4xxx/ql4_isr.c+905 -00 replies
6/8qla4xxx: Mailbox routinesdrivers/scsi/qla4xxx/ql4_mbx.c+1132 -00 replies
7/8qla4xxx: Support routinesdrivers/scsi/qla4xxx/ql4_dbg.c drivers/scsi/qla4xxx/ql4_dbg.h drivers/scsi/qla4xxx/ql4_nvram.c +1 more+992 -00 replies
8/8qla4xxx: Settingsdrivers/scsi/qla4xxx/ql4_settings.h drivers/scsi/qla4xxx/ql4_version.h+135 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] qla4xxx: new driver -- request for review.

All,

Here's a first-pass run for submission-review of the qla4xxx driver for QLogic's ISP4010 and ISP4022 products.

The patchset breaks-down as follows:

o Driver definitions
o initialisation routines
o OS integration files
o iSNS routines
o ISR routines
o Mailbox routines
o Support routines
o Settings

There's still quite a bit of work to do:

- All command-queueing has been removed, so cable-pulls cannot be tolerated. We need to complete the iSCSI transport integration (which seems to no be present).

Are the iSCSI block()/unblock() routines moving forward similarly to FC and now SAS? Mike Christie had submitted patches:

	[PATCH] add block/unblock to iscsi class
	http://marc.theaimsgroup.com/?l=linux-scsi&m=111201856631844&w=2

some time back. Why were the patches dropped?

- Request-queue management cleanup

- iSNS code rework

- Additional cruft removal (unused structures and functions)

All patches can be found at the following URL:

	ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.03b15-k/

Comments and criticisms welcomed.

Regards,
Andrew Vasquez
QLogic Corporation

Signature · 1 line
Andrew Vasquez