Skip to content

ide: Break ide_lock to per-hwgroup lock

Ravikiran G Thirumalai linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ide: Break ide_lock -- Move hwif tuning code after hwif_initdrivers/ide/ide-probe.c+13 -30 replies
2/4ide: Break ide_lock -- replace ide_lock with hwgroup->lock in core idedrivers/ide/ide-cd.c drivers/ide/ide-disk.c drivers/ide/ide-io.c +6 more+136 -1111 reply
3/4ide: Break ide_lock -- change controller driversdrivers/ide/legacy/ht6560b.c drivers/ide/pci/cmd640.c drivers/ide/pci/piix.c+27 -140 replies
4/4ide: Break ide_lock -- remove ide_lock from piix driverdrivers/ide/pci/piix.c+0 -23 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/4] ide: Break ide_lock to per-hwgroup lock

The following patchset breaks down the global ide_lock to per-hwgroup lock. We have taken the following approach.

1. Move the hwif tuning code from probe_hwif to ideprobe_init, after hwif_init so that hwgroups are present for all the hwifs when the tune routines for the hwifs are invoked (patch 1)

2. Change the core ide code to use hwgroup->lock instead of ide_lock. Deprecate ide_lock (patch 2)

3. Change the host controllers to use hwgroup->lock (patch 3)

4. Change host controller drivers to use per driver lock instead of ide_lock where needed or hwgroup->lock on case by case basis. This can be done incrementally for various controllers and we will have working code between patches -- this is done now for piix controller only. Eventually, we can change all controllers to remove ide_lock

Thanks to Bartlomiej for comments and suggestions.

Patchset follows. Patchset tested on a smp box with a piix controller.

Thanks,
Kiran