Skip to content

HTTP refactoring/cleanup

Nick Hengeveld git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Isolate shared HTTP request functionalityMakefile http-fetch.c http-push.c +2 more+635 -9760 replies
2/5Make http-fetch request types more clearhttp-fetch.c+139 -1360 replies
3/5Improve pack list response handlinghttp-fetch.c+10 -20 replies
4/5Improve XML parsing in http-pushhttp-push.c+163 -1560 replies
5/5http-push memory/fd cleanuphttp-push.c+14 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] HTTP refactoring/cleanup

The following set of patches cleans up http-fetch and http-push.

- Common HTTP code has been moved to http.c/http.h. While curl-specific code still exists in both http-fetch and http-push, it is a step in the direction of allowing use of a different HTTP request library if someone is so inclined.

- Object request functions and data have been renamed to keep clear what types of requests are being processed, which will make it easier to process additional types of requests in parallel (eg. starting pack downloads immediately when an object 404s)

- The reliability and performance of http-fetch has been improved when built in an environment without curl multi support.

- XML parsing in http-push has been improved, which will make it easier to add functionality to update remote server info.

Signature · 2 lines
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.