Skip to content

-mm patches to replace pci_module_init() with pci_register_driver()

Richard Knutsson lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drivers: Replace pci_module_init() with pci_register_driver() in -mmdrivers/edac/amd76x_edac.c drivers/edac/e7xxx_edac.c drivers/edac/r82600_edac.c +9 more+12 -120 replies
2/3sound: Replace pci_module_init() with pci_register_driver() in -mmsound/oss/ad1889.c sound/oss/btaudio.c sound/oss/cmpci.c +14 more+17 -170 replies
3/3pci.h:include/linux/pci.h+2 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 2.6.15-rc3-mm1 0/3] -mm patches to replace pci_module_init() with pci_register_driver()

An additional serie to replace the obsolete pci_module_init() with pci_register_driver() in the -mm tree. Last patch #if 0's pci_module_init().

Because pci_module_init() is implemented as:
pci.h:352 #define pci_module_init pci_register_driver the replacment should not effect anything.

Doing "find . -name *.[chS] | xargs grep -n pci_module_init" in the patched tree results in:
./sound/oss/es1371.c:97: * Use pci_module_init
./include/linux/pci.h:350: * pci_module_init is obsolete, this stays here till we fix up all usages of it
./include/linux/pci.h:353:#define pci_module_init pci_register_driver
./drivers/net/3c59x.c:41: - Set vortex_have_pci if pci_module_init returns zero (fixes cardbus
./drivers/media/dvb/b2c2/flexcop-pci.c:418:static int __init flexcop_pci_module_init(void) ./drivers/media/dvb/b2c2/flexcop-pci.c:428:module_init(flexcop_pci_module_init);

It is just sent to lkml in hope that the changes are to small and to spread for mailing every maintainer. Will you pick this up too, Andrew?

Any comment is welcome.

/Richard