Skip to content

mutex subsystem, -V12

Ingo Molnar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 of 19 patches 2 repliesIn review

17 of 19 patches are in this archive. The cover letter announces 19.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19mutex subsystem, add atomic_xchg() to all archesinclude/asm-alpha/atomic.h include/asm-arm/atomic.h include/asm-arm26/atomic.h +19 more+29 -00 replies
2/19mutex subsystem, add typecheck_fn(type, function)include/linux/kernel.h+9 -00 replies
3/19mutex subsystem, add asm-generic/mutex-[dec|xchg|null].h implementationsinclude/asm-generic/mutex-dec.h include/asm-generic/mutex-null.h include/asm-generic/mutex-xchg.h+238 -00 replies
4/19mutex subsystem, add include/asm-i386/mutex.hinclude/asm-i386/mutex.h+136 -00 replies
5/19mutex subsystem, add include/asm-x86_64/mutex.hinclude/asm-x86_64/mutex.h+113 -00 replies
6/19mutex subsystem, add include/asm-arm/mutex.hinclude/asm-arm/mutex.h+128 -00 replies
7/19mutex subsystem, add default include/asm-*/mutex.h filesinclude/asm-alpha/mutex.h include/asm-cris/mutex.h include/asm-frv/mutex.h +16 more+171 -00 replies
8/19mutex subsystem, coreinclude/linux/mutex.h kernel/Makefile kernel/mutex.c +1 more+498 -10 replies
9/19mutex subsystem, documentationDocumentation/mutex-design.txt+134 -00 replies
10/19mutex subsystem, debugging codeinclude/linux/mutex-debug.h include/linux/sched.h kernel/Makefile +4 more+637 -00 replies
11/19mutex subsystem, more debugging codearch/i386/mm/pageattr.c drivers/char/sysrq.c include/linux/mm.h +4 more+37 -00 replies
12/19mutex subsystem, semaphore to mutex: XFSfs/xfs/linux-2.6/mutex.h fs/xfs/quota/xfs_dquot.c fs/xfs/quota/xfs_qm.c +7 more+22 -260 replies
14/19mutex subsystem, semaphore to mutex: VFS, ->i_sem, morefs/cifs/inode.c fs/ext2/acl.c fs/ext2/ext2.h +37 more+103 -1070 replies
16/19mutex subsystem, semaphore to completion: SX8drivers/block/sx8.c+6 -60 replies
17/19mutex subsystem, semaphore to completion: CPU3WDTdrivers/char/watchdog/cpu5wdt.c+5 -40 replies
18/19mutex subsystem, semaphore to completion: IDE ->gendev_rel_semdrivers/ide/ide-probe.c drivers/ide/ide.c include/linux/ide.h+9 -80 replies
19/19mutex subsystem, semaphore to completion: drivers/block/loop.cdrivers/block/loop.c include/linux/loop.h+14 -170 replies

Reviews trailers per patch

None of the 17 patches has a Reviewed-by or Acked-by.

PatchIngo MolnarSteven Rostedt
1/19
2/19Modified-by
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
14/19
16/19
17/19
18/19Modified-by
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/19] mutex subsystem, -V12

this is version -V12 of the generic mutex subsystem, against v2.6.15. It consists of the following 19 patches:

add-atomic-xchg.patch
add-function-typecheck.patch

mutex-generic-asm-implementations.patch
mutex-asm-mutex.h-i386.patch
mutex-asm-mutex.h-x86_64.patch
mutex-asm-mutex.h-arm.patch
mutex-arch-mutex-h.patch
mutex-core.patch

mutex-docs.patch
mutex-debug.patch
mutex-debug-more.patch

sem2mutex-xfs.patch
sem2mutex-vfs-i-sem.patch
sem2mutex-vfs-i-sem-more.patch
sem2mutex-simple-ones.patch

sem2completion-sx8.patch
sem2completion-cpu5wdt.patch
sem2completion-ide-gendev.patch
sem2completion-loop.patch

the patches should work fine on every Linux architecture. They can also be downloaded from:

http://redhat.com/~mingo/generic-mutex-subsystem/

Changes since -V11:

  2 files changed, 50 insertions(+), 138 deletions(-)

- removed asm/semaphore.h from sx8.c (noticed by Nick Piggin)

- simplified the mutex locking slowpath, and merged the interruptible and non-interruptible variants. This also fixes a small queueing-fairness bug noticed by David Howells: tasks woken up by some _other_ waitqueue might jump the wait-queue in the previous code, and create unfairness. In this queueing variant we keep the task queued all the time - if it retries it simply stays at the head of the queue. This should also be more efficient. mutex.o got 10% smaller as well, as the result of the unification of logic.

- cleanup: removed smaller inlined-once functions and merged them into their usage sites.

Ingo