Skip to content

spufs fixes and cleanups

Arnd Bergmann lkml 1 version In review

Get series with b4
b4 am 20060104193120.050539000@localhost

Versions newest first

  1. v1 Latest13 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13spufs: fix locking in spu_acquire_runnablearch/powerpc/platforms/cell/spufs/context.c+6 -40 replies
2/13spufs: dont hold root->isem in spu_forgetarch/powerpc/platforms/cell/spufs/inode.c+10 -100 replies
3/13spufs: check for proper file pointer in sys_spu_runarch/powerpc/platforms/cell/spufs/inode.c arch/powerpc/platforms/cell/spufs/spufs.h arch/powerpc/platforms/cell/spufs/syscalls.c+5 -30 replies
4/13spufs: serialize sys_spu_run per spuarch/powerpc/platforms/cell/spufs/context.c arch/powerpc/platforms/cell/spufs/file.c arch/powerpc/platforms/cell/spufs/spufs.h+12 -50 replies
5/13spufs fix spu_acquire_runnable error patharch/powerpc/platforms/cell/spufs/context.c+2 -20 replies
6/13spufs: dont leak directories in failed spu_createarch/powerpc/platforms/cell/spufs/inode.c+37 -170 replies
7/13spufs: fix spufs_fill_dir error patharch/powerpc/platforms/cell/spufs/inode.c+38 -350 replies
8/13spufs: clean up use of bitopsarch/powerpc/platforms/cell/spu_base.c arch/powerpc/platforms/cell/spufs/sched.c arch/powerpc/platforms/cell/spufs/spufs.h +2 more+14 -170 replies
9/13spufs: move spu_run call to its own filearch/powerpc/platforms/cell/spufs/Makefile arch/powerpc/platforms/cell/spufs/file.c arch/powerpc/platforms/cell/spufs/run.c +1 more+160 -1530 replies
10/13spufs: abstract priv1 register access.arch/powerpc/platforms/cell/Makefile arch/powerpc/platforms/cell/spu_base.c arch/powerpc/platforms/cell/spu_priv1.c +3 more+234 -1360 replies
11/13spufs: fix sparse warningsarch/powerpc/platforms/cell/spu_base.c arch/powerpc/platforms/cell/spufs/inode.c arch/powerpc/platforms/cell/spufs/spufs.h +1 more+5 -60 replies
12/13spufs: fix allocation on 64k pagesinclude/asm-powerpc/spu.h+1 -30 replies
13/13spufs: set irq affinity for running threadsarch/powerpc/platforms/cell/interrupt.c arch/powerpc/platforms/cell/interrupt.h arch/powerpc/platforms/cell/spu_base.c +2 more+41 -162 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] spufs fixes and cleanups

In a review almost a month ago, Al Viro found numerous problems in the current spufs code. I now finally found some time to go through those and attempt to fix them.

There are also a few other changes in this series that should also help, in particular improved interrupt sending and an abstraction for priviledged register access (as suggested by Masato Noguchi and Geoff Levand).

Please apply to powerpc.git before sending spufs upstream.

Al, could you have a look over this to see if it addresses all the concerns you had and if I broke it in new ways?

	Arnd <><
 arch/powerpc/platforms/cell/Makefile         |    5
 arch/powerpc/platforms/cell/interrupt.c      |   42 ++--
 arch/powerpc/platforms/cell/interrupt.h      |    1
 arch/powerpc/platforms/cell/spu_base.c       |   67 +++----
 arch/powerpc/platforms/cell/spu_priv1.c      |  133 ++++++++++++++
 arch/powerpc/platforms/cell/spufs/Makefile   |    2
 arch/powerpc/platforms/cell/spufs/file.c     |  167 +----------------
 arch/powerpc/platforms/cell/spufs/hw_ops.c   |   19 --
 arch/powerpc/platforms/cell/spufs/inode.c    |  156 ++++++++-------
 arch/powerpc/platforms/cell/spufs/run.c      |  131 ++++++++++++++
 arch/powerpc/platforms/cell/spufs/sched.c    |   13 +
 arch/powerpc/platforms/cell/spufs/spufs.h    |   35 +++
 arch/powerpc/platforms/cell/spufs/switch.c   |  139 +++++----------
 arch/powerpc/platforms/cell/spufs/syscalls.c |    5
 arch/powerpc/platforms/cell/spufs/context.c  |   11 -
 include/asm-powerpc/spu.h                    |   42 +++-
  20 files changed, 565 insertions(+), 407 deletions(-)