Skip to content

mutex subsystem, -V15

Ingo Molnar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 of 21 patches 5 repliesIn review

19 of 21 patches are in this archive. The cover letter announces 21.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21mutex subsystem, add atomic_xchg() to all archesinclude/asm-alpha/atomic.h include/asm-arm/atomic.h include/asm-arm26/atomic.h +19 more+29 -01 reply
2/21mutex subsystem, add typecheck_fn(type, function)include/linux/kernel.h+9 -00 replies
3/21mutex subsystem, add asm-generic/mutex-[dec|xchg|null].h implementationsinclude/asm-generic/mutex-dec.h include/asm-generic/mutex-null.h include/asm-generic/mutex-xchg.h+238 -01 reply
4/21mutex subsystem, add include/asm-i386/mutex.hinclude/asm-i386/mutex.h+124 -00 replies
5/21mutex subsystem, add include/asm-x86_64/mutex.hinclude/asm-x86_64/mutex.h+113 -00 replies
6/21mutex subsystem, add include/asm-arm/mutex.hinclude/asm-arm/mutex.h+128 -01 reply
7/21mutex subsystem, add default include/asm-*/mutex.h filesinclude/asm-alpha/mutex.h include/asm-cris/mutex.h include/asm-frv/mutex.h +16 more+171 -00 replies
8/21mutex subsystem, coreinclude/linux/mutex.h kernel/Makefile kernel/mutex.c +1 more+480 -10 replies
9/21mutex subsystem, documentationDocumentation/DocBook/kernel-locking.tmpl Documentation/mutex-design.txt+149 -80 replies
10/21mutex subsystem, debugging codeinclude/linux/mutex-debug.h include/linux/sched.h kernel/Makefile +4 more+637 -02 replies
11/21mutex subsystem, more debugging codearch/i386/mm/pageattr.c drivers/char/sysrq.c include/linux/mm.h +4 more+37 -00 replies
12/21mutex subsystem, synchro-test moduleDocumentation/synchro-test.txt kernel/Makefile kernel/synchro-test.c +1 more+601 -00 replies
13/21mutex subsystem, semaphore to mutex: XFSfs/xfs/linux-2.6/mutex.h fs/xfs/quota/xfs_dquot.c fs/xfs/quota/xfs_qm.c +7 more+22 -260 replies
15/21mutex subsystem, semaphore to mutex: VFS, ->i_sem, morefs/cifs/inode.c fs/ext2/acl.c fs/ext2/ext2.h +37 more+103 -1070 replies
16/21mutex subsystem, semaphore to mutex: VFS, sb->s_lockfs/ext3/super.c fs/super.c include/linux/fs.h+5 -50 replies
18/21mutex subsystem, semaphore to completion: SX8drivers/block/sx8.c+6 -60 replies
19/21mutex subsystem, semaphore to completion: CPU3WDTdrivers/char/watchdog/cpu5wdt.c+5 -40 replies
20/21mutex subsystem, semaphore to completion: IDE ->gendev_rel_semdrivers/ide/ide-probe.c drivers/ide/ide.c include/linux/ide.h+9 -80 replies
21/21mutex subsystem, semaphore to completion: drivers/block/loop.cdrivers/block/loop.c include/linux/loop.h+14 -170 replies

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by.

PatchIngo MolnarSteven Rostedt
1/21
2/21Modified-by
3/21
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
15/21
16/21
18/21
19/21
20/21Modified-by
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/21] mutex subsystem, -V15

this is version 15 of the generic mutex subsystem, against v2.6.15.

The patch-queue consists of 21 patches, which can also be downloaded from:

http://redhat.com/~mingo/generic-mutex-subsystem/

Changes since -V14:

 5 files changed, 164 insertions(+), 191 deletions(-)

- micro-optimization #1: changed waiter->ti to be waiter->task, this shaved off 2 more instructions from the slowpath. Suggested by David Howells.

- micro-optimization #2: beware, this is evil black magic: i've enabled architectures to do tail-merging of the slowpath if they want to, and implemented this on x86. This shaves off another 3 instructions from the slowpath, which can now directly branch into the slowpath function, and the ret from there will bring us back to the call site. The cost is that no other code but the fastpath must be put into mutex_lock()/_unlock(). I have added big warnings to the affected places. The non-assembly generic includes, nor the debugging code is affected by this.

- reordered the API functions to be in likelyhood-of-use order:
mutex_lock()-fastpath, mutex_unlock()-fastpath, mutex_lock()-slowpath, mutex_unlock()-slowpath, mutex_lock_interruptible() fastpath/slowpath, mutex_trylock().

- cleanup: got rid of the intermediate __mutex_lock()/__mutex_unlock() wrappers, they were unnecessary. Renamed the _noinline functions to _slowpath - this is more descriptive.

Ingo