RFC IBM eHCA InfiniBand adapter driver
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest21 of 22 patches 33 repliesIn review
21 of 22 patches are in this archive. The cover letter announces 22.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | Add powerpc-specific clear_cacheline(), which just compiles to "dcbz".drivers/ | +58 | 2 replies | |
| 2/22 | Firmware interface code for IB device.drivers/ | +2022 | 17 replies | |
| 3/22 | pHype specific stuffdrivers/ drivers/ drivers/ | +493 | 2 replies | |
| 4/22 | OF adapter probingdrivers/ drivers/ | +280 | 3 replies | |
| 5/22 | HW register abstractionsdrivers/ drivers/ drivers/ +1 more | +642 | 0 replies | |
| 6/22 | Queue handlingdrivers/ drivers/ drivers/ | +454 | 0 replies | |
| 7/22 | Hypercall definitionsdrivers/ | +115 | 1 reply | |
| 8/22 | Generic ehca headersdrivers/ drivers/ drivers/ | +640 | 1 reply | |
| 9/22 | ehca classesdrivers/ drivers/ drivers/ +1 more | +889 | 0 replies | |
| 11/22 | ehca event queuesdrivers/ drivers/ | +320 | 0 replies | |
| 12/22 | ehca low-level verbsdrivers/ drivers/ | +437 | 0 replies | |
| 13/22 | HCA query functionsdrivers/ | +321 | 0 replies | |
| 14/22 | ehca completion queue handlingdrivers/ | +416 | 0 replies | |
| 15/22 | ehca queue pair handlingdrivers/ | +1528 | 0 replies | |
| 16/22 | ehca post send/receive and poll CQdrivers/ drivers/ | +821 | 0 replies | |
| 17/22 | Special QP functionsdrivers/ | +135 | 0 replies | |
| 18/22 | ehca address vectors, multicast groups, protection domainsdrivers/ drivers/ drivers/ | +552 | 0 replies | |
| 19/22 | ehca memory regionsdrivers/ drivers/ | +2450 | 0 replies | |
| 20/22 | ehca userspace verbsdrivers/ | +376 | 0 replies | |
| 21/22 | ehca main filedrivers/ | +1032 | 4 replies | |
| 22/22 | ehca Makefile/Kconfig changesdrivers/ drivers/ drivers/ +1 more | +17 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/22] [RFC] IBM eHCA InfiniBand adapter driver
Here's a series of patches that add an InfiniBand adapter driver for IBM eHCA hardware. Please look it over with an eye towards issues that need to be addressed before merging this upstream.
This patch series is somewhat unusual in that I am not the original author of this driver -- I am just sending it for review for the authors, who are apparently not able to post patches themselves due to internal issues at IBM. However they are cc'ed and will respond to comments in this thread.
In fact I have some issues with the code myself that need to be addressed before this driver is mergeable. I've included most of them in the individual patches, although I have some general comments too. However I would like to get some early feedback for the ehca authors from the wider community. In particular I think its important to run this past the ppc64 experts, since I'm not sure what the standards for this sort of pSeries driver are.
Anyway, my general comments:
- The #ifs that test EHCA_USERDRIVER and __KERNEL__ should be killed. We know that this is kernel code, so there's no reason to include userspace compatibility junk.
- Many of the comments look like they are for some automatic documentation system that is not quite kerneldoc. They should be fixed to be real kerneldoc comments.
- In general there is a huge amount of code in large inline functions in .h files. Things should be reorganized to cut this down to a sane amount.
Thanks,
Roland