Skip to content

SCSI scanning for PQ3 devs

Kurt Garloff linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Try LUN 1 and use bflagsdrivers/scsi/scsi_scan.c+7 -51 reply
1/3Try LUN 1 and use bflagsdrivers/scsi/scsi_scan.c+4 -130 replies
2/3Better log messages for PQ3 devsdrivers/scsi/scsi_scan.c+34 -33 replies
2/3Better log messages for PQ3 devsdrivers/scsi/scsi_scan.c+35 -30 replies
3/3BLIST_ATTACH_PQ3 flagsdrivers/scsi/scsi_devinfo.c drivers/scsi/scsi_scan.c include/scsi/scsi_devinfo.h+4 -10 replies
3/3BLIST_ATTACH_PQ3 flagsdrivers/scsi/scsi_devinfo.c drivers/scsi/scsi_scan.c include/scsi/scsi_devinfo.h+4 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] SCSI scanning for PQ3 devs

Hi,

solving some SCSI scanning problems that have been reported to us, I came up with the followin patch set.

The trouble is that there are devices that report a LUN with peripheral qualifier on LUN0.
We currently don't handle this well yet:
- Blacklist flags are not used to do special handling if needed.
- If the device does NOT support the REPORT_LUNS scan, we won't see any LUN at all, as we don't even look for LUN 1 then.

Yes, such devices do exist, actually, see PATCH3 ..

The patches do:
- Unconditionally at least look for LUN 1 if LUN 0 was a PQ3 device (but abort scanning there is SPARSELUN is not set and no device can be attached to LUN 1)
- Return the blacklist flags for further usage even if LUN 0 was a PQ3 device.
- Improve the scsi logging information for the the user about the PQ3 issue.
- Introduce a blacklist flag BLIST_ATTACH_PQ3 that allows a PQ3 device to be registered with the OS and thus sg can attach to it. Add two devices to the list.
(One could argue that this should be default, but who knows
what virtual scsi driver will break then ...)

Patches are agains 2.6.16, please consider merging for 2.6.17 or shoot back feedback to me.

Best,

Signature · 1 line
Kurt Garloff, Head Architect Linux R&D, Novell Inc.