Skip to content

RFC Sizing zones and holes in an architecture independent manner

Mel Gorman linuxppc-dev lkml 1 version In review

Get series with b4
b4 am 20060411103946.18153.83059.sendpatchset@skynet

Versions newest first

  1. v1 RFC Latest6 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Introduce mechanism for registering active regions of memoryinclude/linux/mm.h include/linux/mmzone.h mm/page_alloc.c+378 -250 replies
2/6Have Power use add_active_range() and free_area_init_nodes()arch/powerpc/Kconfig arch/powerpc/mm/mem.c arch/powerpc/mm/numa.c +2 more+54 -1900 replies
3/6Have x86 use add_active_range() and free_area_init_nodesarch/i386/Kconfig arch/i386/kernel/setup.c arch/i386/kernel/srat.c +1 more+17 -1670 replies
4/6Have x86_64 use add_active_range() and free_area_init_nodesarch/x86_64/Kconfig arch/x86_64/kernel/e820.c arch/x86_64/mm/init.c +3 more+32 -670 replies
5/6Have ia64 use add_active_range() and free_area_init_nodesarch/ia64/Kconfig arch/ia64/mm/contig.c arch/ia64/mm/discontig.c +2 more+30 -890 replies
6/6Break out memory initialisation code from page_alloc.c to mem_init.cmm/Makefile mm/mem_init.c mm/page_alloc.c+1029 -10052 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] [RFC] Sizing zones and holes in an architecture independent manner

(The TO: list are the architecture maintainers according to the MAINTAINERS. Apologies in advance if I got the list wrong)

At a basic level, architectures define structures to record where active ranges of page frames are located. Once located, the code to calculate zone sizes and holes in each architecture is very similar. Some of this zone and hole sizing code is difficult to read for no good reason. This set of patches eliminates the similar-looking architecture-specific code.

The patches introduce a mechanism where architectures register where the active ranges of page frames are with add_active_range(). When all areas have been discovered, free_area_init_nodes() is called to initialise the pgdat and zones. The zone sizes and holes are then calculated in an architecture independent manner.

Patch 1 introduces the mechanism for registering and initialising PFN ranges Patch 2 changes ppc to use the mechanism - 136 arch-specific LOC removed Patch 3 changes x86 to use the mechanism - 150 arch-specific LOC removed Patch 4 changes x86_64 to use the mechanism - 35 arch-specific LOC removed Patch 5 changes ia64 to use the mechanism - 59 arch-specific LOC removed

At this point, there is a net reduction of 27 lines of code and the arch-independent code is a lot easier to read in comparison to some of the arch-specific stuff, particularly in arch/i386/ .

For Patch 6, it was also noted that page_alloc.c has a *lot* of initialisation code which makes the file harder to read than it needs to be. Patch 6 creates a new file mem_init.c and moves a lot of initialisation code from page_alloc.c to it. After the patch is applied, there is still a net reduction of 3 lines of code.

The patches have been successfully boot tested on

o x86, flatmem
o x86, NUMAQ
o PPC64, NUMA
o PPC64, CONFIG_NUMA=n
o x86_64, NUMA with SRAT

The patches have only been *compile tested* for ia64 with a flatmem configuration. At attempt was made to boot test on an ancient RS/6000 but the vanilla kernel does not boot so I have to investigate there.

The net reduction seems small but the big benefit of this set of patches is the reduction of 380 lines of architecture-specific code, some of which is very hairy. There should be a greater net reduction when other architectures use the same mechanisms for zone and hole sizing but I lack the hardware to test on.

Comments?

Additional credit;
Dave Hansen for the initial suggestion and comments on early patches Andy Whitcroft for reviewing early versions and catching numerous errors

 arch/i386/Kconfig          |    8 
 arch/i386/kernel/setup.c   |   19 
 arch/i386/kernel/srat.c    |   98 ----
 arch/i386/mm/discontig.c   |   59 --
 arch/ia64/Kconfig          |    3 
 arch/ia64/mm/contig.c      |   62 --
 arch/ia64/mm/discontig.c   |   43 -
 arch/ia64/mm/init.c        |   10 
 arch/powerpc/Kconfig       |   13 
 arch/powerpc/mm/mem.c      |   50 --
 arch/powerpc/mm/numa.c     |  157 ------
 arch/ppc/Kconfig           |    3 
 arch/ppc/mm/init.c         |   21 
 arch/x86_64/Kconfig        |    3 
 arch/x86_64/kernel/e820.c  |   18 
 arch/x86_64/mm/init.c      |   60 --
 arch/x86_64/mm/numa.c      |   15 
 include/asm-ia64/meminit.h |    1 
 include/asm-x86_64/e820.h  |    1 
 include/asm-x86_64/proto.h |    2 
 include/linux/mm.h         |   14 
 include/linux/mmzone.h     |   15 
 mm/Makefile                |    2 
 mm/mem_init.c              | 1028 +++++++++++++++++++++++++++++++++++++++++++++
 mm/page_alloc.c            |  678 -----------------------------
 25 files changed, 1190 insertions(+), 1193 deletions(-)
Signature · 4 lines
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab