Skip to content

Remove redundant NULL checks before [kv]free

Jesper Juhl lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 5 patches 3 repliesIn review

2 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Remove redundant NULL checks before [kv]free - in fs/fs/ocfs2/vote.c+2 -61 reply
3/5Remove redundant NULL checks before [kv]free - in arch/arch/ia64/kernel/topology.c arch/ia64/sn/kernel/xpc_partition.c arch/powerpc/platforms/powermac/low_i2c.c +2 more+74 -842 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMark Fasheh
1/5A-b
3/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Remove redundant NULL checks before [kv]free

Here's another round of [kv]free NULL check cleanup patches. A few CodingStyle cleanups crept in as well while I was in the area.

This time I think I got all of them (or at least all my script found). If someone wants to take a look at this in the future and want to use the small PHP script I used to find these, then it should be available at ftp://ftp.kernel.org/pub/linux/kernel/people/juhl/scripts/find_kvfree.php shortly (at least I've put it on master.kernel.org, so I assume it'll get out there soon).

Complete diffstat for the series :

 arch/ia64/kernel/topology.c               |    7 --
 arch/ia64/sn/kernel/xpc_partition.c       |    8 --
 arch/powerpc/platforms/powermac/low_i2c.c |    3
 arch/um/kernel/irq.c                      |   93 +++++++++++++++---------------
 arch/um/os-Linux/irq.c                    |   47 +++++++--------
 drivers/char/agp/sgi-agp.c                |    5 -
 drivers/char/hvcs.c                       |   11 +--
 drivers/message/fusion/mptfc.c            |    6 -
 drivers/message/fusion/mptsas.c           |    3
 drivers/net/fs_enet/fs_enet-mii.c         |    3
 drivers/net/wireless/ipw2200.c            |   22 +------
 drivers/scsi/libata-scsi.c                |    4 -
 drivers/video/au1100fb.c                  |    3
 fs/ocfs2/vote.c                           |    8 --
 kernel/auditsc.c                          |    6 -
 net/ipv4/ipcomp.c                         |    7 --
 net/tipc/name_distr.c                     |    3
 17 files changed, 100 insertions(+), 139 deletions(-)

--
Jesper Juhl <[email protected]>