Skip to content

Notify page fault call chain

Anil S Keshavamurthy lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Notify page fault call chain for x86_64arch/x86_64/mm/fault.c include/asm-x86_64/kdebug.h+39 -20 replies
2/7Notify page fault call chain for i386arch/i386/mm/fault.c include/asm-i386/kdebug.h+38 -20 replies
3/7Notify page fault call chain for ia64arch/ia64/mm/fault.c include/asm-ia64/kdebug.h+37 -10 replies
4/7Notify page fault call chain for powerpcarch/powerpc/mm/fault.c include/asm-powerpc/kdebug.h+37 -10 replies
5/7Notify page fault call chain for sparc64arch/sparc64/mm/fault.c include/asm-sparc64/kdebug.h+37 -10 replies
6/7Kprobes registers for notify page faultkernel/kprobes.c+8 -05 replies
7/7Notify page fault call chaininclude/asm-i386/kprobes.h include/asm-ia64/kprobes.h include/asm-powerpc/kprobes.h +3 more+29 -73 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [(take 2)patch 0/7] Notify page fault call chain

Currently in the do_page_fault() code path, we call notify_die(DIE_PAGE_FAULT, ...) to notify the page fault. Since notify_die() is highly overloaded, this page fault notification is currently being sent to all the components
registered with register_die_notification() which uses the same
die_chain to loop for all the registered components which is unnecessary.

In order to optimize the do_page_fault() code path, this critical page fault notification is now moved to different call chain and the test results showed great improvements.

And the kprobes which is interested in this notifications, now registers onto this new call chain only when it need to, i.e Kprobes now registers for page fault notification only when their are an active probes and unregisters from this page fault notification when no probes are active.

I have incorporated all the feedback given by Ananth and Keith and everyone, and thanks for all the review feedback.

Andrew, please apply this patch to your mm tree and I would gladly fix if their are any other issues.

thanks,
Anil Keshavamurthy

--