Skip to content

Fixes for node alignment and flatmem assumptions

Mel Gorman linux-mm lkml 1 version In review

Get series with b4
b4 am 20060519134241.29021.84756.sendpatchset@skynet

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Align the node_mem_map endpoints to a MAX_ORDER boundaryinclude/linux/mmzone.h mm/page_alloc.c+12 -34 replies
2/2FLATMEM relax requirement for memory to start at pfn 0mm/page_alloc.c+13 -40 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMel Gorman
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Fixes for node alignment and flatmem assumptions

After almost 3 days of banging the head on the keyboard, it was discovered why arch-independent zone-sizing failed on IA64 for the configuration posted on http://www.zip.com.au/~akpm/linux/patches/stuff/config-ia64 .

The two patches in this set address the following;

1. The buddy allocator requires that the node_mem_map be aligned on a MAX_ORDER boundary. Patch 1 from Bob Picco's patch aligns the node_map_map correctly.

2. This is the one that was giving me keyboard face. The FLATMEM memory model assumes that

mem_map[0] == NODE_DATA(0)->node_mem_map == PFN 0

This is not the case on IA64 with arch-independent zone sizing because NODE_DATA(0)->node_mem_map starts where the first valid page frame is. On my test machine, that is PFN 1025 but it probably varies. Patch 2 from Andy Whitcroft relaxes the assumption that NODE_DATA(0)->node_mem_map == PFN 0 .

These patches apply to 2.6.17-rc4-mm1 and are independent of architecture-independent zone sizing. Patch 1 in particular fixes a real problem that is just difficult to trigger. However, once applied, have-ia64-use-add_active_range-and-free_area_init_nodes.patch will work again.

2.6.17-rc4-mm1 with this patchset have been boot-tested by me and verified that /proc/zoneinfo is ok on x86, ppc64, x86_64 and ia64 in a variety of configurations. Bob Picco also says that both patches passed a test with mem=750M and 4Gb on a rx2600 (ia64) with large memory holes. They have also been successfully tested with have-ia64-use-add_active_range-and-free_area_init_nodes.patch added back in.

Signature · 10 lines
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>