Skip to content

EDAC Patch Set

Doug Thompson lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6EDAC PCI device to DEVICE cleanupdrivers/edac/edac_mc.c drivers/edac/edac_mc.h+54 -221 reply
2/6EDAC mc numbers refactor 1-of-2drivers/edac/edac_mc.c+0 -430 replies
3/6EDAC mc numbers refactor 2-of-2drivers/edac/edac_mc.c drivers/edac/edac_mc.h+46 -20 replies
4/6EDAC probe1 cleanup 1-of-2+0 -00 replies
5/6EDAC probe1 cleanup 2-of-2+0 -00 replies
6/6EDAC maintainers updateMAINTAINERS+6 -81 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchDoug Thompson
1/6
2/6Signed-of-by
3/6Signed-of-by
4/6Signed-of-by
5/6
6/6Signed-of-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] EDAC Patch Set

This patch set applies to kernel 2.6.17-rc4 fine and to 2.6.17-rc4-mm1 with slight fuzz in the MAINTAINERs file.

The following set of patches to EDAC provide various cleanups of the EDAC core and memory controller drivers. Most of which came from Dave Peterson and from others.

edac-pci_dep.patch
Change MC drivers from using CVS revisions strings for their version number, Now each driver has its own local string.

Remove some PCI dependencies from the core EDAC module. Most of the code changes here are from a patch by Dave Jiang.
It may be best to eventually move the PCI-specific code into a separate source file.

edac-mc_numbers_1_of_2.patch
This is part 1 of a 2-part patch set. The code changes are split into two parts to make the patches more readable.

Remove add_mc_to_global_list(). In next patch, this function will be reimplemented with different semantics.

edac-mc_numbers_2_of_2.patch
This is part 2 of a 2-part patch set.

- Reimplement add_mc_to_global_list() with semantics that allow the caller to determine the ID number for a mem_ctl_info structure. Then modify edac_mc_add_mc() so that the caller specifies the ID number for the new mem_ctl_info structure. Platform-specific code should be able to assign the ID numbers in a platform-specific manner. For instance, on Opteron it makes sense to have the ID of the mem_ctl_info structure match the ID of the node that the memory controller belongs to.

- Modify callers of edac_mc_add_mc() so they use the new semantics.

edac-probe1_cleanup_1_of_2.patch
This is part 1 of a 2-part patch set. The code changes are split into two parts to make the patches more readable.

Add lower-level functions that handle various parts of the initialization done by the xxx_probe1() functions. Some of the xxx_probe1() functions are much too long and complicated (see "Chapter 5: Functions" in Documentation/CodingStyle).
This is part 2 of a 2-part patch set.

Modify the xxx_probe1() functions so they call the lower-level functions created by the first patch in the set.

edac-maintainers.patch
--------
Removed Dave Peterson as per his request as maintainer. Add Mark Gross as maintainer for E752X MC driver

 drivers/edac/amd76x_edac.c                   |   97 ++++---
 drivers/edac/e752x_edac.c                    |  345 ++++++++++++++-------------
 drivers/edac/e7xxx_edac.c                    |  184 +++++++-------
 drivers/edac/edac_mc.c                       |   56 ++--
 drivers/edac/edac_mc.h                       |   20 +
 drivers/edac/i82860_edac.c                   |  132 +++++-----
 drivers/edac/i82875p_edac.c                  |  254 +++++++++++--------
 drivers/edac/r82600_edac.c                   |  139 +++++-----
 linux-2.6.17-rc3/drivers/edac/edac_mc.c      |   43 ---
 linux-2.6.17-rc4/MAINTAINERS                 |   14 -
 linux-2.6.17-rc4/drivers/edac/amd76x_edac.c  |    5 
 linux-2.6.17-rc4/drivers/edac/e752x_edac.c   |    5 
 linux-2.6.17-rc4/drivers/edac/e7xxx_edac.c   |    5 
 linux-2.6.17-rc4/drivers/edac/edac_mc.c      |   46 +++
 linux-2.6.17-rc4/drivers/edac/edac_mc.h      |    2 
 linux-2.6.17-rc4/drivers/edac/i82860_edac.c  |    5 
 linux-2.6.17-rc4/drivers/edac/i82875p_edac.c |    5 
 linux-2.6.17-rc4/drivers/edac/r82600_edac.c  |    5 
 18 files changed, 755 insertions(+), 607 deletions(-)